2024-03-15 09:14:51

by Colin Ian King

Subject: [PATCH][next] iio: accel: adxl367: Remove second semicolon

There is a statement with two semicolons. Remove the second one, it
is redundant.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/iio/accel/adxl367.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
index 210228affb80..5cf4828a5eb5 100644
--- a/drivers/iio/accel/adxl367.c
+++ b/drivers/iio/accel/adxl367.c
@@ -621,7 +621,7 @@ static int _adxl367_set_odr(struct adxl367_state *st, enum adxl367_odr odr)
static int adxl367_set_odr(struct iio_dev *indio_dev, enum adxl367_odr odr)
{
iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
- struct adxl367_state *st = iio_priv(indio_dev);;
+ struct adxl367_state *st = iio_priv(indio_dev);
int ret;

guard(mutex)(&st->lock);
--
2.39.2

2024-03-15 11:47:53

by Nuno Sá

Subject: Re: [PATCH][next] iio: accel: adxl367: Remove second semicolon

On Fri, 2024-03-15 at 09:14 +0000, Colin Ian King wrote:
> There is a statement with two semicolons. Remove the second one, it
> is redundant.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Reviewed-by: Nuno Sa <[email protected]>

>  drivers/iio/accel/adxl367.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
> index 210228affb80..5cf4828a5eb5 100644
> --- a/drivers/iio/accel/adxl367.c
> +++ b/drivers/iio/accel/adxl367.c
> @@ -621,7 +621,7 @@ static int _adxl367_set_odr(struct adxl367_state *st, enum
> adxl367_odr odr)
>  static int adxl367_set_odr(struct iio_dev *indio_dev, enum adxl367_odr odr)
>  {
>   iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
> - struct adxl367_state *st = iio_priv(indio_dev);;
> + struct adxl367_state *st = iio_priv(indio_dev);
>   int ret;
>  
>   guard(mutex)(&st->lock);

2024-03-16 14:06:42

by Jonathan Cameron

Subject: Re: [PATCH][next] iio: accel: adxl367: Remove second semicolon

On Fri, 15 Mar 2024 12:51:07 +0100
Nuno Sá <[email protected]> wrote:

> On Fri, 2024-03-15 at 09:14 +0000, Colin Ian King wrote:
> > There is a statement with two semicolons. Remove the second one, it
> > is redundant.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
> > ---
>
> Reviewed-by: Nuno Sa <[email protected]>
Thanks Colin.

oops.

Applied to the togreg-normal branch of iio.git, but note I'll not rush
this in, so will be the 6.10 merge window now.

Jonathan


>
> >  drivers/iio/accel/adxl367.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
> > index 210228affb80..5cf4828a5eb5 100644
> > --- a/drivers/iio/accel/adxl367.c
> > +++ b/drivers/iio/accel/adxl367.c
> > @@ -621,7 +621,7 @@ static int _adxl367_set_odr(struct adxl367_state *st, enum
> > adxl367_odr odr)
> >  static int adxl367_set_odr(struct iio_dev *indio_dev, enum adxl367_odr odr)
> >  {
> >   iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
> > - struct adxl367_state *st = iio_priv(indio_dev);;
> > + struct adxl367_state *st = iio_priv(indio_dev);
> >   int ret;
> >  
> >   guard(mutex)(&st->lock);
>