2024-03-18 03:07:54

by Li zeming

Subject: [PATCH] blk-pm: Remove unnecessary ‘0’ values from ret

ret is assigned first, so it does not need to initialize the assignment.

Signed-off-by: Li zeming <[email protected]>
---
block/blk-pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-pm.c b/block/blk-pm.c
index 42e8420747153..c76d5a3169417 100644
--- a/block/blk-pm.c
+++ b/block/blk-pm.c
@@ -58,10 +58,10 @@ EXPORT_SYMBOL(blk_pm_runtime_init);
*/
int blk_pre_runtime_suspend(struct request_queue *q)
{
- int ret = 0;
+ int ret;

if (!q->dev)
- return ret;
+ return 0;

WARN_ON_ONCE(q->rpm_status != RPM_ACTIVE);

--
2.18.2

2024-03-19 03:06:49

by Chaitanya Kulkarni

Subject: Re: [PATCH] blk-pm: Remove unnecessary ‘0’ values from ret

On 3/17/24 20:07, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the assignment.
>
> Signed-off-by: Li zeming <[email protected]>
> ---
> block/blk-pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-pm.c b/block/blk-pm.c
> index 42e8420747153..c76d5a3169417 100644
> --- a/block/blk-pm.c
> +++ b/block/blk-pm.c
> @@ -58,10 +58,10 @@ EXPORT_SYMBOL(blk_pm_runtime_init);
> */
> int blk_pre_runtime_suspend(struct request_queue *q)
> {
> - int ret = 0;
> + int ret;
>
> if (!q->dev)
> - return ret;
> + return 0;
>
> WARN_ON_ONCE(q->rpm_status != RPM_ACTIVE);
>

I don't see why we need this patch, existing code is fine ...

-ck