2024-03-17 21:35:57

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the ftrace tree

---

Hi all,

In commit

2fd814ad5713 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")

Fixes tag

Fixes: 5b37b7eb98a19 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")

has these problem(s):

- Target SHA1 does not exist

The Fixes tag seems to be referring to the commit that contains the
Fixes tag :-(

Also, pleas keep all the commit message tags together at the end of the
commit message.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2024-03-17 21:44:04

by Steven Rostedt

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the ftrace tree

---

On Mon, 18 Mar 2024 08:35:35 +1100
Stephen Rothwell <[email protected]> wrote:

> Hi all,
>
> In commit
>
> 2fd814ad5713 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
>
> Fixes tag
>
> Fixes: 5b37b7eb98a19 ("ring-buffer: Make wake once of ring_buffer_wait() more robust")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> The Fixes tag seems to be referring to the commit that contains the
> Fixes tag :-(
>
> Also, pleas keep all the commit message tags together at the end of the
> commit message.
>

Bah, that looks to me to be a cut and paste error. Anyway, I'm rebasing all
of it as one of the commits was nacked by Linus. :-(

-- Steve