2024-03-14 03:35:26

by jianbin zhang

Subject: [PATCH v3 2/2] rtc: rtc-pm8xxx: Correct the PM8xxx_RTC_ALARM_CLEAR vaule in trigger

Change in v3:
*Correct the vaule that writed into the PM8xxx_RTC_ALARM_CLEAR to 1.

Change in v2:
*Switch to using regmap_update_bits() instead of open coding
read-modify-write accesses.
Link to v2: https://lore.kernel.org/lkml/[email protected]/

Signed-off-by: jianbinz <[email protected]>
---
drivers/rtc/rtc-pm8xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
index 1b5a96924e57..8a9be78d0b0b 100644
--- a/drivers/rtc/rtc-pm8xxx.c
+++ b/drivers/rtc/rtc-pm8xxx.c
@@ -391,7 +391,7 @@ static irqreturn_t pm8xxx_alarm_trigger(int irq, void *dev_id)

/* Clear alarm status */
rc = regmap_update_bits(rtc_dd->regmap, regs->alarm_ctrl2,
- PM8xxx_RTC_ALARM_CLEAR, 0);
+ PM8xxx_RTC_ALARM_CLEAR, 1);
if (rc)
return IRQ_NONE;

--
2.17.1

2024-03-19 19:12:33

by Bjorn Andersson

Subject: Re: [PATCH v3 2/2] rtc: rtc-pm8xxx: Correct the PM8xxx_RTC_ALARM_CLEAR vaule in trigger

On Thu, Mar 14, 2024 at 11:34:49AM +0800, jianbinz wrote:
> Change in v3:
> *Correct the vaule that writed into the PM8xxx_RTC_ALARM_CLEAR to 1.
>
> Change in v2:
> *Switch to using regmap_update_bits() instead of open coding
> read-modify-write accesses.
> Link to v2: https://lore.kernel.org/lkml/[email protected]/
>
> Signed-off-by: jianbinz <[email protected]>

Same feedback as on patch 1/2, but on this one you're also completely
missing a commit message clearly describing the problem that your change
is solving.

Regards,
Bjorn

> ---
> drivers/rtc/rtc-pm8xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c
> index 1b5a96924e57..8a9be78d0b0b 100644
> --- a/drivers/rtc/rtc-pm8xxx.c
> +++ b/drivers/rtc/rtc-pm8xxx.c
> @@ -391,7 +391,7 @@ static irqreturn_t pm8xxx_alarm_trigger(int irq, void *dev_id)
>
> /* Clear alarm status */
> rc = regmap_update_bits(rtc_dd->regmap, regs->alarm_ctrl2,
> - PM8xxx_RTC_ALARM_CLEAR, 0);
> + PM8xxx_RTC_ALARM_CLEAR, 1);
> if (rc)
> return IRQ_NONE;
>
> --
> 2.17.1
>