2024-03-20 13:13:09

by Heiko Stuebner

Subject: [PATCH 2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init

From: Heiko Stuebner <[email protected]>

The init sequence specifies the 0x11 and 0x29 dsi commands, which are
the exit-sleep and display-on commands.

In the actual prepare step the driver already uses the appropriate
function calls for those, so drop the duplicates.

Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant")
Signed-off-by: Heiko Stuebner <[email protected]>
---
drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
index a50f5330a661..8e0f5c3e3b98 100644
--- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
+++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c
@@ -295,8 +295,6 @@ static int ltk050h3148w_init_sequence(struct ltk050h3146w *ctx)
mipi_dsi_dcs_write_seq(dsi, 0xbd, 0x00);
mipi_dsi_dcs_write_seq(dsi, 0xc6, 0xef);
mipi_dsi_dcs_write_seq(dsi, 0xd4, 0x02);
- mipi_dsi_dcs_write_seq(dsi, 0x11);
- mipi_dsi_dcs_write_seq(dsi, 0x29);

ret = mipi_dsi_dcs_set_tear_on(dsi, 1);
if (ret < 0) {
--
2.39.2

2024-03-21 14:45:15

by Quentin Schulz

Subject: Re: [PATCH 2/2] drm/panel: ltk050h3146w: drop duplicate commands from LTK050H3148W init

Hi Heiko,

On 3/20/24 14:12, Heiko Stuebner wrote:
> From: Heiko Stuebner <[email protected]>
>
> The init sequence specifies the 0x11 and 0x29 dsi commands, which are
> the exit-sleep and display-on commands.
>
> In the actual prepare step the driver already uses the appropriate
> function calls for those, so drop the duplicates.
>
> Fixes: e5f9d543419c ("drm/panel: ltk050h3146w: add support for Leadtek LTK050H3148W-CTA6 variant")
> Signed-off-by: Heiko Stuebner <[email protected]>

Reviewed-by: Quentin Schulz <[email protected]>

Thanks!
Quentin