2024-03-22 07:04:09

by Vijendar Mukunda

Subject: [PATCH] [RESEND] ASoC: amd: simplify soundwire dependencies for

The CONFIG_SOUNDWIRE_AMD is a user-visible option, it should be never
selected by another driver.
So replace the extra complexity with a normal Kconfig dependency in
SND_SOC_AMD_SOUNDWIRE.

Signed-off-by: Vijendar Mukunda <[email protected]>
---
sound/soc/amd/Kconfig | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index fa74635cee08..3508f5a96b75 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -134,15 +134,14 @@ config SND_SOC_AMD_RPL_ACP6x

config SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
tristate
- select SOUNDWIRE_AMD if SND_SOC_AMD_SOUNDWIRE != n
select SND_AMD_SOUNDWIRE_ACPI if ACPI

config SND_SOC_AMD_SOUNDWIRE
tristate "Support for SoundWire based AMD platforms"
default SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
depends on SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
- depends on ACPI && SOUNDWIRE
- depends on !(SOUNDWIRE=m && SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE=y)
+ depends on ACPI
+ depends on SOUNDWIRE_AMD
help
This adds support for SoundWire for AMD platforms.
Say Y if you want to enable SoundWire links with SOF.
--
2.34.1

2024-03-22 10:46:01

by Vijendar Mukunda

Subject: Re: [PATCH] [RESEND] ASoC: amd: simplify soundwire dependencies for

On 22/03/24 12:33, Vijendar Mukunda wrote:
> The CONFIG_SOUNDWIRE_AMD is a user-visible option, it should be never
> selected by another driver.
> So replace the extra complexity with a normal Kconfig dependency in
> SND_SOC_AMD_SOUNDWIRE.
Please ignore this patch, as the commit title has not been posted
completely.
>
> Signed-off-by: Vijendar Mukunda <[email protected]>
> ---
> sound/soc/amd/Kconfig | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index fa74635cee08..3508f5a96b75 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -134,15 +134,14 @@ config SND_SOC_AMD_RPL_ACP6x
>
> config SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
> tristate
> - select SOUNDWIRE_AMD if SND_SOC_AMD_SOUNDWIRE != n
> select SND_AMD_SOUNDWIRE_ACPI if ACPI
>
> config SND_SOC_AMD_SOUNDWIRE
> tristate "Support for SoundWire based AMD platforms"
> default SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
> depends on SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
> - depends on ACPI && SOUNDWIRE
> - depends on !(SOUNDWIRE=m && SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE=y)
> + depends on ACPI
> + depends on SOUNDWIRE_AMD
> help
> This adds support for SoundWire for AMD platforms.
> Say Y if you want to enable SoundWire links with SOF.