The two patches were previously submitted on their own.
In commit f9436a5d0497
("sysctl: allow to change limits for posix messages queues")
a code dependency was introduced between the two callbacks.
This code dependency results in a dependency between the two patches, so
now they are submitted as a series.
The series is meant to be merged via the sysctl tree.
There is an upcoming series that will introduce a new implementation of
set_ownership and .permissions which would need to be adapted [0].
These changes ere originally part of the sysctl-const series [1].
To slim down that series and reduce the message load on other
maintainers to a minimum, the patches are split out.
[0] https://lore.kernel.org/lkml/[email protected]/
[1] https://lore.kernel.org/lkml/[email protected]/
Signed-off-by: Thomas Weißschuh <[email protected]>
---
Changes in v3:
- Drop now spurious argument in fs/proc/proc_sysctl.c
- Rebase on next-20240315
- Incorporate permissions patch.
- Link to v2 (ownership): https://lore.kernel.org/r/[email protected]
- Link to v1 (permissions): https://lore.kernel.org/r/20231226-sysctl-const-permissions-v1-1-5cd3c91f6299@weissschuh.net
Changes in v2:
- Rework commit message
- Mention potential conflict with upcoming per-namespace kernel.pid_max
sysctl
- Delete unused parameter table
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Thomas Weißschuh (2):
sysctl: treewide: drop unused argument ctl_table_root::set_ownership(table)
sysctl: treewide: constify argument ctl_table_root::permissions(table)
fs/proc/proc_sysctl.c | 2 +-
include/linux/sysctl.h | 3 +--
ipc/ipc_sysctl.c | 5 ++---
ipc/mq_sysctl.c | 5 ++---
kernel/ucount.c | 2 +-
net/sysctl_net.c | 3 +--
6 files changed, 8 insertions(+), 12 deletions(-)
---
base-commit: a1e7655b77e3391b58ac28256789ea45b1685abb
change-id: 20231226-sysctl-const-ownership-ff75e67b4eea
Best regards,
--
Thomas Weißschuh <[email protected]>
On Fri, Mar 15, 2024 at 07:11:29PM +0100, Thomas Wei?schuh wrote:
> The two patches were previously submitted on their own.
> In commit f9436a5d0497
> ("sysctl: allow to change limits for posix messages queues")
> a code dependency was introduced between the two callbacks.
> This code dependency results in a dependency between the two patches, so
> now they are submitted as a series.
>
> The series is meant to be merged via the sysctl tree.
>
> There is an upcoming series that will introduce a new implementation of
> .set_ownership and .permissions which would need to be adapted [0].
>
> These changes ere originally part of the sysctl-const series [1].
> To slim down that series and reduce the message load on other
> maintainers to a minimum, the patches are split out.
>
> [0] https://lore.kernel.org/lkml/[email protected]/
> [1] https://lore.kernel.org/lkml/[email protected]/
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>
> ---
> Changes in v3:
> - Drop now spurious argument in fs/proc/proc_sysctl.c
> - Rebase on next-20240315
> - Incorporate permissions patch.
> - Link to v2 (ownership): https://lore.kernel.org/r/[email protected]
> - Link to v1 (permissions): https://lore.kernel.org/r/20231226-sysctl-const-permissions-v1-1-5cd3c91f6299@weissschuh.net
>
> Changes in v2:
> - Rework commit message
> - Mention potential conflict with upcoming per-namespace kernel.pid_max
> sysctl
> - Delete unused parameter table
> - Link to v1: https://lore.kernel.org/r/[email protected]
>
> ---
> Thomas Wei?schuh (2):
> sysctl: treewide: drop unused argument ctl_table_root::set_ownership(table)
> sysctl: treewide: constify argument ctl_table_root::permissions(table)
>
> fs/proc/proc_sysctl.c | 2 +-
> include/linux/sysctl.h | 3 +--
> ipc/ipc_sysctl.c | 5 ++---
> ipc/mq_sysctl.c | 5 ++---
> kernel/ucount.c | 2 +-
> net/sysctl_net.c | 3 +--
> 6 files changed, 8 insertions(+), 12 deletions(-)
> ---
> base-commit: a1e7655b77e3391b58ac28256789ea45b1685abb
> change-id: 20231226-sysctl-const-ownership-ff75e67b4eea
>
> Best regards,
> --
> Thomas Wei?schuh <[email protected]>
>
Will put this to test and then try to rebase it to 6.9-rc1 once it comes
out.
Thx.
--
Joel Granados
On 2024-03-22 13:47:09+0100, Joel Granados wrote:
> On Fri, Mar 15, 2024 at 07:11:29PM +0100, Thomas Weißschuh wrote:
> > The two patches were previously submitted on their own.
> > In commit f9436a5d0497
> > ("sysctl: allow to change limits for posix messages queues")
> > a code dependency was introduced between the two callbacks.
> > This code dependency results in a dependency between the two patches, so
> > now they are submitted as a series.
> >
> > The series is meant to be merged via the sysctl tree.
> >
> > There is an upcoming series that will introduce a new implementation of
> > .set_ownership and .permissions which would need to be adapted [0].
> >
> > These changes ere originally part of the sysctl-const series [1].
> > To slim down that series and reduce the message load on other
> > maintainers to a minimum, the patches are split out.
> >
> > [0] https://lore.kernel.org/lkml/[email protected]/
> > [1] https://lore.kernel.org/lkml/[email protected]/
> >
> > Signed-off-by: Thomas Weißschuh <[email protected]>
> > ---
> > Changes in v3:
> > - Drop now spurious argument in fs/proc/proc_sysctl.c
> > - Rebase on next-20240315
> > - Incorporate permissions patch.
> > - Link to v2 (ownership): https://lore.kernel.org/r/[email protected]
> > - Link to v1 (permissions): https://lore.kernel.org/r/20231226-sysctl-const-permissions-v1-1-5cd3c91f6299@weissschuh.net
> >
> > Changes in v2:
> > - Rework commit message
> > - Mention potential conflict with upcoming per-namespace kernel.pid_max
> > sysctl
> > - Delete unused parameter table
> > - Link to v1: https://lore.kernel.org/r/[email protected]
> >
> > ---
> > Thomas Weißschuh (2):
> > sysctl: treewide: drop unused argument ctl_table_root::set_ownership(table)
> > sysctl: treewide: constify argument ctl_table_root::permissions(table)
> >
> > fs/proc/proc_sysctl.c | 2 +-
> > include/linux/sysctl.h | 3 +--
> > ipc/ipc_sysctl.c | 5 ++---
> > ipc/mq_sysctl.c | 5 ++---
> > kernel/ucount.c | 2 +-
> > net/sysctl_net.c | 3 +--
> > 6 files changed, 8 insertions(+), 12 deletions(-)
> > ---
> > base-commit: a1e7655b77e3391b58ac28256789ea45b1685abb
> > change-id: 20231226-sysctl-const-ownership-ff75e67b4eea
> >
> > Best regards,
> > --
> > Thomas Weißschuh <[email protected]>
> >
>
> Will put this to test and then try to rebase it to 6.9-rc1 once it comes
> out.
Thanks!
Your changes to the commit messages look good.
For my other changes I'm planning to resubmit all of them during the
weekend or next week.
Thomas