2024-03-25 18:01:07

by Patrice CHOTARD

Subject: [PATCH] ARM: dts: stm32: add heartbeat led for stm32mp157c-ed1

From: Patrice Chotard <[email protected]>

Add heartbeat led for stm32mp157c-ed1.

Signed-off-by: Patrice Chotard <[email protected]>
---
arch/arm/boot/dts/st/stm32mp157c-ed1.dts | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
index 66ed5f9921ba..bd727455a7e4 100644
--- a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
+++ b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
@@ -24,6 +24,15 @@ chosen {
stdout-path = "serial0:115200n8";
};

+ led {
+ compatible = "gpio-leds";
+ led-blue {
+ gpios = <&gpiod 9 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ default-state = "off";
+ };
+ };
+
memory@c0000000 {
device_type = "memory";
reg = <0xC0000000 0x40000000>;
--
2.25.1

2024-03-25 18:43:46

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: dts: stm32: add heartbeat led for stm32mp157c-ed1

On 25/03/2024 18:06, [email protected] wrote:
> From: Patrice Chotard <[email protected]>
>
> Add heartbeat led for stm32mp157c-ed1.
>
> Signed-off-by: Patrice Chotard <[email protected]>
> ---
> arch/arm/boot/dts/st/stm32mp157c-ed1.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
> index 66ed5f9921ba..bd727455a7e4 100644
> --- a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
> +++ b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
> @@ -24,6 +24,15 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + led {
> + compatible = "gpio-leds";
> + led-blue {
> + gpios = <&gpiod 9 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";

Please add function and color properties.

Best regards,
Krzysztof

2024-03-26 07:30:53

by Patrice CHOTARD

Subject: Re: [PATCH] ARM: dts: stm32: add heartbeat led for stm32mp157c-ed1

On 3/25/24 19:29, Krzysztof Kozlowski wrote:
> On 25/03/2024 18:06, [email protected] wrote:
>> From: Patrice Chotard <[email protected]>
>>
>> Add heartbeat led for stm32mp157c-ed1.
>>
>> Signed-off-by: Patrice Chotard <[email protected]>
>> ---
>> arch/arm/boot/dts/st/stm32mp157c-ed1.dts | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
>> index 66ed5f9921ba..bd727455a7e4 100644
>> --- a/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
>> +++ b/arch/arm/boot/dts/st/stm32mp157c-ed1.dts
>> @@ -24,6 +24,15 @@ chosen {
>> stdout-path = "serial0:115200n8";
>> };
>>
>> + led {
>> + compatible = "gpio-leds";
>> + led-blue {
>> + gpios = <&gpiod 9 GPIO_ACTIVE_HIGH>;
>> + linux,default-trigger = "heartbeat";
>> + default-state = "off";
>
> Please add function and color properties.
Hi Krzysztof

OK i will send a v2

Thanks
Patrice

>
> Best regards,
> Krzysztof
>