2024-03-27 02:05:55

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH v2 0/6] arm64: dts: qcom: qcs6490-rb3gen2: Enable two displays

RB3Gen2 is capable of producing DisplayPort output on a dedicated
mini-DP connector and USB Type-C.

Utilize Abel's work for DP vs eDP selection to allow configuring both
controllers in DP-mode, then enable the two output paths.

Tested by driving fbcon to 4k@60 + 4k@30 concurrently.

Depends on 20240324-x1e80100-display-refactor-connector-v4-0-e0ebaea66a78@linaro.org

---
Changes in v2:
- Rebased on Abel's updated implementation
- Dropped DP driver changes, as Abel's new DP/eDP selection mechanism
obsoleted these.
- Squashed the two separate patches adding pmic-glink
- Corrected remoteproc firmware-name paths
- Described the mini-DP connector in DT, and hence no longer use the
internal HPD handler in DP driver
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Bjorn Andersson (6):
arm64: dts: qcom: sc7280: Enable MDP turbo mode
arm64: dts: qcom: qcs6490-rb3gen2: Add DP output
arm64: dts: qcom: qcs6490-rb3gen2: Enable adsp and cdsp
arm64: dts: qcom: qcs6490-rb3gen2: Introduce USB redriver
arm64: dts: qcom: qcs6490-rb3gen2: Enable USB Type-C display
arm64: defconfig: Enable sc7280 display and gpu clock controllers

arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 171 ++++++++++++++++++++++++++-
arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 +
arch/arm64/configs/defconfig | 2 +
3 files changed, 177 insertions(+), 1 deletion(-)
---
base-commit: f27830a6a17b722f9dbbccfaae1f3bae8700c672
change-id: 20240209-rb3gen2-dp-connector-bddfb892ff20

Best regards,
--
Bjorn Andersson <[email protected]>



2024-03-27 02:12:18

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH v2 3/6] arm64: dts: qcom: qcs6490-rb3gen2: Enable adsp and cdsp

Define firmware paths and enable the ADSP and CDSP remoteprocs.

Signed-off-by: Bjorn Andersson <[email protected]>
---
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index f90bf3518e98..5b267a94a282 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -508,6 +508,16 @@ &qupv3_id_0 {
status = "okay";
};

+&remoteproc_adsp {
+ firmware-name = "qcom/qcs6490/adsp.mbn";
+ status = "okay";
+};
+
+&remoteproc_cdsp {
+ firmware-name = "qcom/qcs6490/cdsp.mbn";
+ status = "okay";
+};
+
&tlmm {
gpio-reserved-ranges = <32 2>, /* ADSP */
<48 4>; /* NFC */

--
2.25.1


2024-03-27 02:12:19

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH v2 6/6] arm64: defconfig: Enable sc7280 display and gpu clock controllers

Enable the SC7280 display and gpu clock controllers to enable display
support on the QCS6490 RB3gen2.

Reviewed-by: Dmitry Baryshkov <[email protected]>
Signed-off-by: Bjorn Andersson <[email protected]>
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 6c45a465a071..a25a28e6117b 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1287,6 +1287,7 @@ CONFIG_QCM_DISPCC_2290=m
CONFIG_QCS_GCC_404=y
CONFIG_QDU_GCC_1000=y
CONFIG_SC_CAMCC_8280XP=m
+CONFIG_SC_DISPCC_7280=m
CONFIG_SC_DISPCC_8280XP=m
CONFIG_SA_GCC_8775P=y
CONFIG_SA_GPUCC_8775P=m
@@ -1294,6 +1295,7 @@ CONFIG_SC_GCC_7180=y
CONFIG_SC_GCC_7280=y
CONFIG_SC_GCC_8180X=y
CONFIG_SC_GCC_8280XP=y
+CONFIG_SC_GPUCC_7280=m
CONFIG_SC_GPUCC_8280XP=m
CONFIG_SC_LPASSCC_8280XP=m
CONFIG_SDM_CAMCC_845=m

--
2.25.1


2024-03-28 01:55:14

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: qcs6490-rb3gen2: Enable adsp and cdsp

On Wed, 27 Mar 2024 at 04:04, Bjorn Andersson <[email protected]> wrote:
>
> Define firmware paths and enable the ADSP and CDSP remoteprocs.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)

Reviewed-by: Dmitry Baryshkov <[email protected]>


--
With best wishes
Dmitry

2024-04-04 21:27:46

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v2 0/6] arm64: dts: qcom: qcs6490-rb3gen2: Enable two displays


On Tue, 26 Mar 2024 19:04:17 -0700, Bjorn Andersson wrote:
> RB3Gen2 is capable of producing DisplayPort output on a dedicated
> mini-DP connector and USB Type-C.
>
> Utilize Abel's work for DP vs eDP selection to allow configuring both
> controllers in DP-mode, then enable the two output paths.
>
> Tested by driving fbcon to 4k@60 + 4k@30 concurrently.
>
> [...]

Applied, thanks!

[6/6] arm64: defconfig: Enable sc7280 display and gpu clock controllers
commit: a97b6c42a7b823c429fac562a02d291b47b98d7e

Best regards,
--
Bjorn Andersson <[email protected]>