2024-03-26 12:23:23

by Hariprasad Kelam

[permalink] [raw]
Subject: [net Patch] octeontx2-af: Fix issue with loading coalesced KPU profiles

The current implementation for loading coalesced KPU profiles has
a limitation. The "offset" field, which is used to locate profiles
within the profile is restricted to a u16.

This restricts the number of profiles that can be loaded. This patch
addresses this limitation by increasing the size of the "offset" field.

Fixes: 11c730bfbf5b ("octeontx2-af: support for coalescing KPU profiles")
Signed-off-by: Hariprasad Kelam <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
index e350242bbafb..be709f83f331 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
@@ -1657,7 +1657,7 @@ static int npc_fwdb_detect_load_prfl_img(struct rvu *rvu, uint64_t prfl_sz,
struct npc_coalesced_kpu_prfl *img_data = NULL;
int i = 0, rc = -EINVAL;
void __iomem *kpu_prfl_addr;
- u16 offset;
+ u32 offset;

img_data = (struct npc_coalesced_kpu_prfl __force *)rvu->kpu_prfl_addr;
if (le64_to_cpu(img_data->signature) == KPU_SIGN &&
--
2.17.1



2024-03-26 16:54:30

by Kalesh Anakkur Purayil

[permalink] [raw]
Subject: Re: [net Patch] octeontx2-af: Fix issue with loading coalesced KPU profiles

On Tue, Mar 26, 2024 at 5:53 PM Hariprasad Kelam <[email protected]> wrote:
>
> The current implementation for loading coalesced KPU profiles has
> a limitation. The "offset" field, which is used to locate profiles
> within the profile is restricted to a u16.
>
> This restricts the number of profiles that can be loaded. This patch
> addresses this limitation by increasing the size of the "offset" field.
>
> Fixes: 11c730bfbf5b ("octeontx2-af: support for coalescing KPU profiles")
> Signed-off-by: Hariprasad Kelam <[email protected]>
LGTM
Reviewed-by: Kalesh AP <[email protected]>
> ---
> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> index e350242bbafb..be709f83f331 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> @@ -1657,7 +1657,7 @@ static int npc_fwdb_detect_load_prfl_img(struct rvu *rvu, uint64_t prfl_sz,
> struct npc_coalesced_kpu_prfl *img_data = NULL;
> int i = 0, rc = -EINVAL;
> void __iomem *kpu_prfl_addr;
> - u16 offset;
> + u32 offset;
>
> img_data = (struct npc_coalesced_kpu_prfl __force *)rvu->kpu_prfl_addr;
> if (le64_to_cpu(img_data->signature) == KPU_SIGN &&
> --
> 2.17.1
>
>


--
Regards,
Kalesh A P

Attachments:
smime.p7s (4.14 kB)
S/MIME Cryptographic Signature

2024-03-29 11:50:38

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [net Patch] octeontx2-af: Fix issue with loading coalesced KPU profiles

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

On Tue, 26 Mar 2024 17:51:49 +0530 you wrote:
> The current implementation for loading coalesced KPU profiles has
> a limitation. The "offset" field, which is used to locate profiles
> within the profile is restricted to a u16.
>
> This restricts the number of profiles that can be loaded. This patch
> addresses this limitation by increasing the size of the "offset" field.
>
> [...]

Here is the summary with links:
- [net] octeontx2-af: Fix issue with loading coalesced KPU profiles
https://git.kernel.org/netdev/net/c/0ba80d965856

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html