2024-03-25 22:07:02

by Bjorn Helgaas

[permalink] [raw]
Subject: [PATCH] net: amd8111e: Drop unused copy of pm_cap

From: Bjorn Helgaas <[email protected]>

The copy of pdev->pm_cap in struct amd8111e_priv is never used. Drop it.

Signed-off-by: Bjorn Helgaas <[email protected]>
---
drivers/net/ethernet/amd/amd8111e.c | 1 -
drivers/net/ethernet/amd/amd8111e.h | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c
index ea6cfc2095e1..c1b5e9a94308 100644
--- a/drivers/net/ethernet/amd/amd8111e.c
+++ b/drivers/net/ethernet/amd/amd8111e.c
@@ -1796,7 +1796,6 @@ static int amd8111e_probe_one(struct pci_dev *pdev,
lp = netdev_priv(dev);
lp->pci_dev = pdev;
lp->amd8111e_net_dev = dev;
- lp->pm_cap = pdev->pm_cap;

spin_lock_init(&lp->lock);

diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h
index 9d570adb295b..305232f5476d 100644
--- a/drivers/net/ethernet/amd/amd8111e.h
+++ b/drivers/net/ethernet/amd/amd8111e.h
@@ -764,7 +764,6 @@ struct amd8111e_priv{
u32 ext_phy_id;

struct amd8111e_link_config link_config;
- int pm_cap;

struct net_device *next;
int mii;
--
2.34.1



2024-03-26 14:52:04

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] net: amd8111e: Drop unused copy of pm_cap

On Mon, Mar 25, 2024 at 05:06:33PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> The copy of pdev->pm_cap in struct amd8111e_priv is never used. Drop it.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>

Reviewed-by: Simon Horman <[email protected]>


2024-03-27 04:09:54

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: amd8111e: Drop unused copy of pm_cap

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Mon, 25 Mar 2024 17:06:33 -0500 you wrote:
> From: Bjorn Helgaas <[email protected]>
>
> The copy of pdev->pm_cap in struct amd8111e_priv is never used. Drop it.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>
> ---
> drivers/net/ethernet/amd/amd8111e.c | 1 -
> drivers/net/ethernet/amd/amd8111e.h | 1 -
> 2 files changed, 2 deletions(-)

Here is the summary with links:
- net: amd8111e: Drop unused copy of pm_cap
https://git.kernel.org/netdev/net-next/c/ee36b1e93b11

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html