2024-03-27 02:11:02

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the selinux tree

Hi all,

After merging the selinux tree, today's linux-next build (i386 defconfig)
failed like this:

In file included from include/linux/kernel.h:31,
from security/selinux/ss/ebitmap.c:16:
security/selinux/ss/ebitmap.c: In function 'ebitmap_read':
include/linux/kern_levels.h:5:25: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'u32' {aka 'unsigned int'} [-Werror=format=]
5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
| ^~~~~~
include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~
include/linux/printk.h:500:9: note: in expansion of macro 'printk'
500 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
11 | #define KERN_ERR KERN_SOH "3" /* error conditions */
| ^~~~~~~~
include/linux/printk.h:500:16: note: in expansion of macro 'KERN_ERR'
500 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~
security/selinux/ss/ebitmap.c:464:17: note: in expansion of macro 'pr_err'
464 | pr_err("SELinux: ebitmap: high bit %d is not equal to the expected value %ld\n",
| ^~~~~~
cc1: all warnings being treated as errors

Caused by commit

0142c56682fb ("selinux: reject invalid ebitmaps")

I have reverted that commit for today.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2024-03-27 16:13:56

by Paul Moore

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the selinux tree

On Tue, Mar 26, 2024 at 10:10 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the selinux tree, today's linux-next build (i386 defconfig)
> failed like this:
>
> In file included from include/linux/kernel.h:31,
> from security/selinux/ss/ebitmap.c:16:
> security/selinux/ss/ebitmap.c: In function 'ebitmap_read':
> include/linux/kern_levels.h:5:25: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'u32' {aka 'unsigned int'} [-Werror=format=]
> 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */
> | ^~~~~~
> include/linux/printk.h:429:25: note: in definition of macro 'printk_index_wrap'
> 429 | _p_func(_fmt, ##__VA_ARGS__); \
> | ^~~~
> include/linux/printk.h:500:9: note: in expansion of macro 'printk'
> 500 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~
> include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
> 11 | #define KERN_ERR KERN_SOH "3" /* error conditions */
> | ^~~~~~~~
> include/linux/printk.h:500:16: note: in expansion of macro 'KERN_ERR'
> 500 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
> | ^~~~~~~~
> security/selinux/ss/ebitmap.c:464:17: note: in expansion of macro 'pr_err'
> 464 | pr_err("SELinux: ebitmap: high bit %d is not equal to the expected value %ld\n",
> | ^~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 0142c56682fb ("selinux: reject invalid ebitmaps")
>
> I have reverted that commit for today.

Thanks Stephen, if I don't see a fix from Christian soon I'll patch it
myself. It should be resolved later today.

--
paul-moore.com