2024-03-28 02:24:52

by Jiapeng Chong

Subject: [PATCH] io_uring: Remove unused function

The function are defined in the io_uring.c file, but not called
elsewhere, so delete the unused function.

io_uring/io_uring.c:646:20: warning: unused function '__io_cq_unlock'.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8660
Signed-off-by: Jiapeng Chong <[email protected]>
---
io_uring/io_uring.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
index 585fbc363eaf..8a9584c5c8ce 100644
--- a/io_uring/io_uring.c
+++ b/io_uring/io_uring.c
@@ -643,12 +643,6 @@ static inline void __io_cq_lock(struct io_ring_ctx *ctx)
spin_lock(&ctx->completion_lock);
}

-static inline void __io_cq_unlock(struct io_ring_ctx *ctx)
-{
- if (!ctx->lockless_cq)
- spin_unlock(&ctx->completion_lock);
-}
-
static inline void io_cq_lock(struct io_ring_ctx *ctx)
__acquires(ctx->completion_lock)
{
--
2.20.1.7.g153144c

2024-03-28 13:44:46

by Jens Axboe

Subject: Re: [PATCH] io_uring: Remove unused function

On Thu, 28 Mar 2024 10:23:24 +0800, Jiapeng Chong wrote:
> The function are defined in the io_uring.c file, but not called
> elsewhere, so delete the unused function.
>
> io_uring/io_uring.c:646:20: warning: unused function '__io_cq_unlock'.
>
>

Applied, thanks!

[1/1] io_uring: Remove unused function
commit: 976a421d86422abb554b4544ddcad31f1cade3a4

Best regards,
--
Jens Axboe