2024-03-20 16:38:36

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH v4 09/11] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

---

On Wed, Mar 20, 2024 at 03:55:57PM +0530, Bhargav Raviprakash wrote:

> +static struct tps6594_regulator_irq_type tps65224_buck1_irq_types[] = {
> + { TPS65224_IRQ_NAME_BUCK1_UVOV, "BUCK1", "voltage out of range",
> + REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> +};

These all look like they should be _REGULATION_OUT given that the
interrupt names are _UVOV which look like they could be either under or
over voltage.

Otherwise this all looks good.

---

Attachments:

(No filename) (460.00 B)
signature.asc (499.00 B)
Download all attachments

2024-03-28 10:37:57

by Bhargav Raviprakash

[permalink] [raw]

Subject: Re: [PATCH v4 09/11] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators

---

Hi,

On Wed, 20 Mar 2024 16:38:20 +0000, Mark Brown wrote:
> On Wed, Mar 20, 2024 at 03:55:57PM +0530, Bhargav Raviprakash wrote:
>
> > +static struct tps6594_regulator_irq_type tps65224_buck1_irq_types[] = {
> > + { TPS65224_IRQ_NAME_BUCK1_UVOV, "BUCK1", "voltage out of range",
> > + REGULATOR_EVENT_OVER_VOLTAGE_WARN },
> > +};
>
> These all look like they should be _REGULATION_OUT given that the
> interrupt names are _UVOV which look like they could be either under or
> over voltage.
>
> Otherwise this all looks good.

Thanks for the feedback! We will fix it in the next version.

Regards,
Bhargav