2024-03-29 09:17:55

by Kelvin Zhang via B4 Relay

Subject: [PATCH 2/3] reset: reset-meson: add support for Amlogic T7 SoC Reset Controller

From: Zelong Dong <[email protected]>

There are 7 sets of Reset Source in Amlogic T7 SoC Reset Controller,
and the offset between base and level registers is 0x40.
Add a new compatible string and struct meson_reset_param to support
the reset controller on T7 SoC.

Signed-off-by: Zelong Dong <[email protected]>
Signed-off-by: Kelvin Zhang <[email protected]>
---
drivers/reset/reset-meson.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
index f78be97898bc..1e9fca3e30e8 100644
--- a/drivers/reset/reset-meson.c
+++ b/drivers/reset/reset-meson.c
@@ -102,6 +102,11 @@ static const struct meson_reset_param meson_s4_param = {
.level_offset = 0x40,
};

+static const struct meson_reset_param t7_param = {
+ .reg_count = 7,
+ .level_offset = 0x40,
+};
+
static const struct of_device_id meson_reset_dt_ids[] = {
{ .compatible = "amlogic,meson8b-reset", .data = &meson8b_param},
{ .compatible = "amlogic,meson-gxbb-reset", .data = &meson8b_param},
@@ -109,6 +114,7 @@ static const struct of_device_id meson_reset_dt_ids[] = {
{ .compatible = "amlogic,meson-a1-reset", .data = &meson_a1_param},
{ .compatible = "amlogic,meson-s4-reset", .data = &meson_s4_param},
{ .compatible = "amlogic,c3-reset", .data = &meson_s4_param},
+ { .compatible = "amlogic,t7-reset", .data = &t7_param},
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, meson_reset_dt_ids);

--
2.37.1

2024-03-29 09:25:48

by Neil Armstrong

Subject: Re: [PATCH 2/3] reset: reset-meson: add support for Amlogic T7 SoC Reset Controller

On 29/03/2024 10:17, Kelvin Zhang via B4 Relay wrote:
> From: Zelong Dong <[email protected]>
>
> There are 7 sets of Reset Source in Amlogic T7 SoC Reset Controller,
> and the offset between base and level registers is 0x40.
> Add a new compatible string and struct meson_reset_param to support
> the reset controller on T7 SoC.
>
> Signed-off-by: Zelong Dong <[email protected]>
> Signed-off-by: Kelvin Zhang <[email protected]>
> ---
> drivers/reset/reset-meson.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index f78be97898bc..1e9fca3e30e8 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -102,6 +102,11 @@ static const struct meson_reset_param meson_s4_param = {
> .level_offset = 0x40,
> };
>
> +static const struct meson_reset_param t7_param = {
> + .reg_count = 7,
> + .level_offset = 0x40,
> +};
> +
> static const struct of_device_id meson_reset_dt_ids[] = {
> { .compatible = "amlogic,meson8b-reset", .data = &meson8b_param},
> { .compatible = "amlogic,meson-gxbb-reset", .data = &meson8b_param},
> @@ -109,6 +114,7 @@ static const struct of_device_id meson_reset_dt_ids[] = {
> { .compatible = "amlogic,meson-a1-reset", .data = &meson_a1_param},
> { .compatible = "amlogic,meson-s4-reset", .data = &meson_s4_param},
> { .compatible = "amlogic,c3-reset", .data = &meson_s4_param},
> + { .compatible = "amlogic,t7-reset", .data = &t7_param},
> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, meson_reset_dt_ids);
>

Reviewed-by: Neil Armstrong <[email protected]>

2024-03-29 09:25:58

by Neil Armstrong

Subject: Re: [PATCH 2/3] reset: reset-meson: add support for Amlogic T7 SoC Reset Controller

On 29/03/2024 10:17, Kelvin Zhang via B4 Relay wrote:
> From: Zelong Dong <[email protected]>
>
> There are 7 sets of Reset Source in Amlogic T7 SoC Reset Controller,
> and the offset between base and level registers is 0x40.
> Add a new compatible string and struct meson_reset_param to support
> the reset controller on T7 SoC.
>
> Signed-off-by: Zelong Dong <[email protected]>
> Signed-off-by: Kelvin Zhang <[email protected]>
> ---
> drivers/reset/reset-meson.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index f78be97898bc..1e9fca3e30e8 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -102,6 +102,11 @@ static const struct meson_reset_param meson_s4_param = {
> .level_offset = 0x40,
> };
>
> +static const struct meson_reset_param t7_param = {
> + .reg_count = 7,
> + .level_offset = 0x40,
> +};
> +
> static const struct of_device_id meson_reset_dt_ids[] = {
> { .compatible = "amlogic,meson8b-reset", .data = &meson8b_param},
> { .compatible = "amlogic,meson-gxbb-reset", .data = &meson8b_param},
> @@ -109,6 +114,7 @@ static const struct of_device_id meson_reset_dt_ids[] = {
> { .compatible = "amlogic,meson-a1-reset", .data = &meson_a1_param},
> { .compatible = "amlogic,meson-s4-reset", .data = &meson_s4_param},
> { .compatible = "amlogic,c3-reset", .data = &meson_s4_param},
> + { .compatible = "amlogic,t7-reset", .data = &t7_param},
> { /* sentinel */ },
> };
> MODULE_DEVICE_TABLE(of, meson_reset_dt_ids);
>

Reviewed-by: Neil Armstrong <[email protected]>