2024-03-29 20:33:30

by Shresth Prasad

Subject: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c

Align some function arguments to the opening parenthesis of the
function as reported by checkpatch:

CHECK: Alignment should match open parenthesis

Signed-off-by: Shresth Prasad <[email protected]>
---
drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index c51818c56dd2..a70af76be7fb 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -376,8 +376,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
*/
mutex_lock(&fifo->read_lock);
ret = wait_event_interruptible_timeout(fifo->read_queue,
- ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
- read_timeout);
+ ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
+ read_timeout);

if (ret <= 0) {
if (ret == 0) {
@@ -517,9 +517,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
*/
mutex_lock(&fifo->write_lock);
ret = wait_event_interruptible_timeout(fifo->write_queue,
- ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
- >= words_to_write,
- write_timeout);
+ ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+ >= words_to_write,
+ write_timeout);

if (ret <= 0) {
if (ret == 0) {
--
2.44.0

2024-03-30 21:34:48

by Uri Arev

Subject: Re: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c

> Align some function arguments to the opening parenthesis of the
> function as reported by checkpatch:
Hey, I sent a similar patch around a month ago and got no reply.
Good luck with that :)

Uri Arev

2024-03-31 02:19:54

by Shresth Prasad

Subject: Re: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c

Oh, that's too bad. Thanks for the heads up!

Regards,
Shresth Prasad

2024-03-31 18:34:47

by Uri Arev

Subject: Re: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c

> Oh, that's too bad. Thanks for the heads up!
No worries, I wouldn't mind it if your patch got accepted and not mine
:p
I just don't think they accept patches to axis-fifo anymore, especially
not basic syntax and checkpatch patches which are not as important as
actual bug-fixes.

Uri Arev

2024-04-02 07:16:10

by Dan Carpenter

Subject: Re: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c

On Sun, Mar 31, 2024 at 09:33:55PM +0300, Uri Arev wrote:
> > Oh, that's too bad. Thanks for the heads up!
> No worries, I wouldn't mind it if your patch got accepted and not mine
> :p
> I just don't think they accept patches to axis-fifo anymore, especially
> not basic syntax and checkpatch patches which are not as important as
> actual bug-fixes.

No, we're always taking patches. You just had bad luck/timing where you
sent the patch 2 days before Greg went on vacation.

Greg is back now, but I imagine he has a long list of stuff to catch up
with. It's possible that he also accidentally dropped your patch
because of the vacation... I could imagine a situation where that
happened.

regards,
dan carpenter

2024-04-02 14:00:21

by Shresth Prasad

Subject: Re: [PATCH] staging: axis-fifo: align arguments to open parenthesis in axis-fifo.c

>No, we're always taking patches. You just had bad luck/timing where you
>sent the patch 2 days before Greg went on vacation.

>Greg is back now, but I imagine he has a long list of stuff to catch up
>with. It's possible that he also accidentally dropped your patch
>because of the vacation... I could imagine a situation where that
>happened.

That's quite unfortunate. It's good to know that you guys are still
taking patches tho!

Regards,
Shresth Prasad