2024-03-30 20:38:44

by Krzysztof Kozlowski

Subject: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/sti/sti_dvo.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index fd1df4ce3852..00502889c7f4 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -581,7 +581,6 @@ MODULE_DEVICE_TABLE(of, dvo_of_match);
struct platform_driver sti_dvo_driver = {
.driver = {
.name = "sti-dvo",
- .owner = THIS_MODULE,
.of_match_table = dvo_of_match,
},
.probe = sti_dvo_probe,
--
2.34.1

2024-03-30 20:38:52

by Krzysztof Kozlowski

Subject: [PATCH 2/4] drm/sti: hda: drop driver owner assignment

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/sti/sti_hda.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
index 6ee35612a14e..f18faad974aa 100644
--- a/drivers/gpu/drm/sti/sti_hda.c
+++ b/drivers/gpu/drm/sti/sti_hda.c
@@ -807,7 +807,6 @@ MODULE_DEVICE_TABLE(of, hda_of_match);
struct platform_driver sti_hda_driver = {
.driver = {
.name = "sti-hda",
- .owner = THIS_MODULE,
.of_match_table = hda_of_match,
},
.probe = sti_hda_probe,
--
2.34.1

2024-03-30 20:39:15

by Krzysztof Kozlowski

Subject: [PATCH 4/4] drm/sti: vtg: drop driver owner assignment

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/sti/sti_vtg.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
index 5e5f82b6a5d9..5ba469b711b5 100644
--- a/drivers/gpu/drm/sti/sti_vtg.c
+++ b/drivers/gpu/drm/sti/sti_vtg.c
@@ -431,7 +431,6 @@ MODULE_DEVICE_TABLE(of, vtg_of_match);
struct platform_driver sti_vtg_driver = {
.driver = {
.name = "sti-vtg",
- .owner = THIS_MODULE,
.of_match_table = vtg_of_match,
},
.probe = vtg_probe,
--
2.34.1

2024-03-30 20:39:17

by Krzysztof Kozlowski

Subject: [PATCH 3/4] drm/sti: tvout: drop driver owner assignment

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/sti/sti_tvout.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
index 64615638b79a..e714c232026c 100644
--- a/drivers/gpu/drm/sti/sti_tvout.c
+++ b/drivers/gpu/drm/sti/sti_tvout.c
@@ -886,7 +886,6 @@ MODULE_DEVICE_TABLE(of, tvout_of_match);
struct platform_driver sti_tvout_driver = {
.driver = {
.name = "sti-tvout",
- .owner = THIS_MODULE,
.of_match_table = tvout_of_match,
},
.probe = sti_tvout_probe,
--
2.34.1

2024-03-30 20:57:37

by Krzysztof Kozlowski

Subject: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---

I forgot two drivers.
drivers/gpu/drm/sti/sti_hdmi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index 500936d5743c..b0d84440a87b 100644
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
struct platform_driver sti_hdmi_driver = {
.driver = {
.name = "sti-hdmi",
- .owner = THIS_MODULE,
.of_match_table = hdmi_of_match,
},
.probe = sti_hdmi_probe,
--
2.34.1

2024-03-30 20:57:47

by Krzysztof Kozlowski

Subject: [PATCH 6/6] drm/sti: hqvdp: drop driver owner assignment

Core in platform_driver_register() already sets the .owner, so driver
does not need to. Whatever is set here will be anyway overwritten by
main driver calling platform_driver_register().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/sti/sti_hqvdp.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 0fb48ac044d8..acbf70b95aeb 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -1414,7 +1414,6 @@ MODULE_DEVICE_TABLE(of, hqvdp_of_match);
struct platform_driver sti_hqvdp_driver = {
.driver = {
.name = "sti-hqvdp",
- .owner = THIS_MODULE,
.of_match_table = hqvdp_of_match,
},
.probe = sti_hqvdp_probe,
--
2.34.1

2024-04-24 06:45:51

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

On 30/03/2024 21:38, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

It has been almost a month. Any comments? Anything is happening here?

Best regards,
Krzysztof

2024-05-27 15:08:27

by Alain Volmat

Subject: Re: [PATCH 3/4] drm/sti: tvout: drop driver owner assignment

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:30PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/sti/sti_tvout.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
> index 64615638b79a..e714c232026c 100644
> --- a/drivers/gpu/drm/sti/sti_tvout.c
> +++ b/drivers/gpu/drm/sti/sti_tvout.c
> @@ -886,7 +886,6 @@ MODULE_DEVICE_TABLE(of, tvout_of_match);
> struct platform_driver sti_tvout_driver = {
> .driver = {
> .name = "sti-tvout",
> - .owner = THIS_MODULE,
> .of_match_table = tvout_of_match,
> },
> .probe = sti_tvout_probe,
> --
> 2.34.1
>
Acked-by: Alain Volmat <[email protected]>

Alain

2024-05-27 15:14:52

by Alain Volmat

Subject: Re: [PATCH 2/4] drm/sti: hda: drop driver owner assignment

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:29PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/sti/sti_hda.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
> index 6ee35612a14e..f18faad974aa 100644
> --- a/drivers/gpu/drm/sti/sti_hda.c
> +++ b/drivers/gpu/drm/sti/sti_hda.c
> @@ -807,7 +807,6 @@ MODULE_DEVICE_TABLE(of, hda_of_match);
> struct platform_driver sti_hda_driver = {
> .driver = {
> .name = "sti-hda",
> - .owner = THIS_MODULE,
> .of_match_table = hda_of_match,
> },
> .probe = sti_hda_probe,
> --
> 2.34.1
>

Acked-by: Alain Volmat <[email protected]>

Alain

2024-05-27 15:19:18

by Alain Volmat

Subject: Re: [PATCH 4/4] drm/sti: vtg: drop driver owner assignment

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:31PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/sti/sti_vtg.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index 5e5f82b6a5d9..5ba469b711b5 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -431,7 +431,6 @@ MODULE_DEVICE_TABLE(of, vtg_of_match);
> struct platform_driver sti_vtg_driver = {
> .driver = {
> .name = "sti-vtg",
> - .owner = THIS_MODULE,
> .of_match_table = vtg_of_match,
> },
> .probe = vtg_probe,
> --
> 2.34.1
>
Acked-by: Alain Volmat <[email protected]>

Alain

2024-05-27 15:20:01

by Alain Volmat

Subject: Re: [PATCH 6/6] drm/sti: hqvdp: drop driver owner assignment

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:57:22PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/sti/sti_hqvdp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index 0fb48ac044d8..acbf70b95aeb 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -1414,7 +1414,6 @@ MODULE_DEVICE_TABLE(of, hqvdp_of_match);
> struct platform_driver sti_hqvdp_driver = {
> .driver = {
> .name = "sti-hqvdp",
> - .owner = THIS_MODULE,
> .of_match_table = hqvdp_of_match,
> },
> .probe = sti_hqvdp_probe,
> --
> 2.34.1
>
Acked-by: Alain Volmat <[email protected]>

Alain

2024-05-27 15:36:36

by Alain Volmat

Subject: Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

Hi Krzysztof,

thanks for your patch, sorry for the delay.

On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
>
> I forgot two drivers.
> drivers/gpu/drm/sti/sti_hdmi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index 500936d5743c..b0d84440a87b 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
> struct platform_driver sti_hdmi_driver = {
> .driver = {
> .name = "sti-hdmi",
> - .owner = THIS_MODULE,
> .of_match_table = hdmi_of_match,
> },
> .probe = sti_hdmi_probe,
> --
> 2.34.1
>

Acked-by: Alain Volmat <[email protected]>

Alain

2024-05-27 16:02:45

by Alain Volmat

Subject: Re: [PATCH 1/4] drm/sti: dvo: drop driver owner assignment

Hi Krzysztof,

sorry for the delay.

On Sat, Mar 30, 2024 at 09:38:28PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to. Whatever is set here will be anyway overwritten by
> main driver calling platform_driver_register().
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/sti/sti_dvo.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
> index fd1df4ce3852..00502889c7f4 100644
> --- a/drivers/gpu/drm/sti/sti_dvo.c
> +++ b/drivers/gpu/drm/sti/sti_dvo.c
> @@ -581,7 +581,6 @@ MODULE_DEVICE_TABLE(of, dvo_of_match);
> struct platform_driver sti_dvo_driver = {
> .driver = {
> .name = "sti-dvo",
> - .owner = THIS_MODULE,
> .of_match_table = dvo_of_match,
> },
> .probe = sti_dvo_probe,
> --
> 2.34.1
>

Acked-by: Alain Volmat <[email protected]>

Alain

2024-06-04 13:19:58

by Krzysztof Kozlowski

Subject: Re: [PATCH 5/6] drm/sti: hdmi: drop driver owner assignment

On 27/05/2024 16:47, Alain Volmat wrote:
> Hi Krzysztof,
>
> thanks for your patch, sorry for the delay.
>
> On Sat, Mar 30, 2024 at 09:57:21PM +0100, Krzysztof Kozlowski wrote:
>> Core in platform_driver_register() already sets the .owner, so driver
>> does not need to. Whatever is set here will be anyway overwritten by
>> main driver calling platform_driver_register().
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>>
>> I forgot two drivers.
>> drivers/gpu/drm/sti/sti_hdmi.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
>> index 500936d5743c..b0d84440a87b 100644
>> --- a/drivers/gpu/drm/sti/sti_hdmi.c
>> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
>> @@ -1485,7 +1485,6 @@ static void sti_hdmi_remove(struct platform_device *pdev)
>> struct platform_driver sti_hdmi_driver = {
>> .driver = {
>> .name = "sti-hdmi",
>> - .owner = THIS_MODULE,
>> .of_match_table = hdmi_of_match,
>> },
>> .probe = sti_hdmi_probe,
>> --
>> 2.34.1
>>
>
> Acked-by: Alain Volmat <[email protected]>

What does this ack mean? You are the maintainer, so what is supposed to
happen now? If maintainer does not take patches, then the DRM STI looks
orphaned.

Best regards,
Krzysztof