2024-04-02 09:56:44

by Dan Carpenter

Subject: [PATCH] drm/panthor: Fix error code in panthor_gpu_init()

This code accidentally returns zero/success on error because of a typo.
It should be "irq" instead of "ret". The other thing is that if
platform_get_irq_byname() were to return zero then the error code would
be cmplicated. Fortunately, it does not so we can just change <= to
< 0.

Fixes: 5cd894e258c4 ("drm/panthor: Add the GPU logical block")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/gpu/drm/panthor/panthor_gpu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c
index 0f7c962440d3..5251d8764e7d 100644
--- a/drivers/gpu/drm/panthor/panthor_gpu.c
+++ b/drivers/gpu/drm/panthor/panthor_gpu.c
@@ -211,8 +211,8 @@ int panthor_gpu_init(struct panthor_device *ptdev)
return ret;

irq = platform_get_irq_byname(to_platform_device(ptdev->base.dev), "gpu");
- if (irq <= 0)
- return ret;
+ if (irq < 0)
+ return irq;

ret = panthor_request_gpu_irq(ptdev, &ptdev->gpu->irq, irq, GPU_INTERRUPTS_MASK);
if (ret)
--
2.43.0

2024-04-02 12:22:02

by Boris Brezillon

Subject: Re: [PATCH] drm/panthor: Fix error code in panthor_gpu_init()

On Tue, 2 Apr 2024 12:56:19 +0300
Dan Carpenter <[email protected]> wrote:

> This code accidentally returns zero/success on error because of a typo.
> It should be "irq" instead of "ret". The other thing is that if
> platform_get_irq_byname() were to return zero then the error code would
> be cmplicated. Fortunately, it does not so we can just change <= to
> < 0.
>
> Fixes: 5cd894e258c4 ("drm/panthor: Add the GPU logical block")
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Boris Brezillon <[email protected]>

> ---
> drivers/gpu/drm/panthor/panthor_gpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c
> index 0f7c962440d3..5251d8764e7d 100644
> --- a/drivers/gpu/drm/panthor/panthor_gpu.c
> +++ b/drivers/gpu/drm/panthor/panthor_gpu.c
> @@ -211,8 +211,8 @@ int panthor_gpu_init(struct panthor_device *ptdev)
> return ret;
>
> irq = platform_get_irq_byname(to_platform_device(ptdev->base.dev), "gpu");
> - if (irq <= 0)
> - return ret;
> + if (irq < 0)
> + return irq;
>
> ret = panthor_request_gpu_irq(ptdev, &ptdev->gpu->irq, irq, GPU_INTERRUPTS_MASK);
> if (ret)

2024-04-03 07:21:11

by Boris Brezillon

Subject: Re: [PATCH] drm/panthor: Fix error code in panthor_gpu_init()

On Tue, 2 Apr 2024 12:56:19 +0300
Dan Carpenter <[email protected]> wrote:

> This code accidentally returns zero/success on error because of a typo.
> It should be "irq" instead of "ret". The other thing is that if
> platform_get_irq_byname() were to return zero then the error code would
> be cmplicated. Fortunately, it does not so we can just change <= to
> < 0.
>
> Fixes: 5cd894e258c4 ("drm/panthor: Add the GPU logical block")
> Signed-off-by: Dan Carpenter <[email protected]>

Queued to drm-misc-next.

Thanks,

Boris

> ---
> drivers/gpu/drm/panthor/panthor_gpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c
> index 0f7c962440d3..5251d8764e7d 100644
> --- a/drivers/gpu/drm/panthor/panthor_gpu.c
> +++ b/drivers/gpu/drm/panthor/panthor_gpu.c
> @@ -211,8 +211,8 @@ int panthor_gpu_init(struct panthor_device *ptdev)
> return ret;
>
> irq = platform_get_irq_byname(to_platform_device(ptdev->base.dev), "gpu");
> - if (irq <= 0)
> - return ret;
> + if (irq < 0)
> + return irq;
>
> ret = panthor_request_gpu_irq(ptdev, &ptdev->gpu->irq, irq, GPU_INTERRUPTS_MASK);
> if (ret)