2024-04-02 20:29:33

by Krzysztof Kozlowski

Subject: [PATCH 1/2] arm64: dts: apm: storm: move non-MMIO node out of soc

Non-MMIO devices, like fixed-clocks, should not be within simple-bus.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/apm/apm-storm.dtsi | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi
index 988928c60f15..633d8418f7cc 100644
--- a/arch/arm64/boot/dts/apm/apm-storm.dtsi
+++ b/arch/arm64/boot/dts/apm/apm-storm.dtsi
@@ -112,6 +112,13 @@ gic: interrupt-controller@78010000 {
interrupts = <1 9 0xf04>; /* GIC Maintenence IRQ */
};

+ refclk: refclk {
+ compatible = "fixed-clock";
+ #clock-cells = <1>;
+ clock-frequency = <100000000>;
+ clock-output-names = "refclk";
+ };
+
timer {
compatible = "arm,armv8-timer";
interrupts = <1 0 0xff08>, /* Secure Phys IRQ */
@@ -137,12 +144,6 @@ clocks {
#address-cells = <2>;
#size-cells = <2>;
ranges;
- refclk: refclk {
- compatible = "fixed-clock";
- #clock-cells = <1>;
- clock-frequency = <100000000>;
- clock-output-names = "refclk";
- };

pcppll: pcppll@17000100 {
compatible = "apm,xgene-pcppll-clock";
--
2.34.1

2024-04-24 06:57:36

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] arm64: dts: apm: storm: move non-MMIO node out of soc

On Tue, 02 Apr 2024 22:08:17 +0200, Krzysztof Kozlowski wrote:
> Non-MMIO devices, like fixed-clocks, should not be within simple-bus.
>

Almost a month passed, no replies from maintainers about picking it up. Dunno,
looks abandoned, so let me grab this. If anyone else wants to pick it up, let
me know.

Applied, thanks!

[1/2] arm64: dts: apm: storm: move non-MMIO node out of soc
https://git.kernel.org/krzk/linux-dt/c/0fbadd0568e4dab360d4d3092d236ce5fafb24ed
[2/2] arm64: dts: apm: shadowcat: move non-MMIO node out of soc
https://git.kernel.org/krzk/linux-dt/c/4a3e011b7b9955f030df1423c7a54f7e4bd874bd

Best regards,
--
Krzysztof Kozlowski <[email protected]>