2024-04-02 23:14:32

by Shenghao Ding

Subject: [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data

fixed tas2781 calibrated data - pow was written into a wrong register.

Signed-off-by: Shenghao Ding <[email protected]>
---
sound/pci/hda/tas2781_hda_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 48dae3339305..116821ae3cb3 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -514,10 +514,10 @@ static int tas2563_save_calibration(struct tasdevice_priv *tas_priv)
static void tas2781_apply_calib(struct tasdevice_priv *tas_priv)
{
static const unsigned char page_array[CALIB_MAX] = {
- 0x17, 0x18, 0x18, 0x0d, 0x18
+ 0x17, 0x18, 0x18, 0x13, 0x18
};
static const unsigned char rgno_array[CALIB_MAX] = {
- 0x74, 0x0c, 0x14, 0x3c, 0x7c
+ 0x74, 0x0c, 0x14, 0x70, 0x7c
};
unsigned char *data;
int i, j, rc;
--
2.34.1

2024-04-03 10:06:50

by Andy Shevchenko

Subject: Re: [PATCH v1] ALSA: hda/tas2781: correct the register for pow calibrated data

On Wed, Apr 03, 2024 at 07:12:59AM +0800, Shenghao Ding wrote:
> fixed tas2781 calibrated data - pow was written into a wrong register.

fixed --> Fix

Fixes tag?

> Signed-off-by: Shenghao Ding <[email protected]>

..

> + 0x17, 0x18, 0x18, 0x13, 0x18
> + 0x74, 0x0c, 0x14, 0x70, 0x7c

While at it, can you add a trailing comma?
It will help in case of extending this in the future.

--
With Best Regards,
Andy Shevchenko