2024-04-03 04:44:20

by Chen Ni

Subject: [PATCH v2] ata: sata_gemini: Add check for clk_enable

The call to clk_enable() in gemini_sata_start_bridge() can fail.
Add a check to detect such failure.

Signed-off-by: Chen Ni <[email protected]>
---
Changelog:

v1 -> v2:
1. Simplify commit message
---
drivers/ata/sata_gemini.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
index 400b22ee99c3..4c270999ba3c 100644
--- a/drivers/ata/sata_gemini.c
+++ b/drivers/ata/sata_gemini.c
@@ -200,7 +200,10 @@ int gemini_sata_start_bridge(struct sata_gemini *sg, unsigned int bridge)
pclk = sg->sata0_pclk;
else
pclk = sg->sata1_pclk;
- clk_enable(pclk);
+ ret = clk_enable(pclk);
+ if (ret)
+ return ret;
+
msleep(10);

/* Do not keep clocking a bridge that is not online */
--
2.25.1

2024-04-04 03:44:12

by Damien Le Moal

Subject: Re: [PATCH v2] ata: sata_gemini: Add check for clk_enable

On 4/3/24 13:33, Chen Ni wrote:
> The call to clk_enable() in gemini_sata_start_bridge() can fail.
> Add a check to detect such failure.
>
> Signed-off-by: Chen Ni <[email protected]>

Applied to for-6.9-fixes. Thanks !

--
Damien Le Moal
Western Digital Research