2024-04-06 13:22:14

by Shenghao Ding

Subject: [PATCH v3] ALSA: hda/tas2781: correct the register for pow calibrated data

Calibrated data was written into an incorrect register, which cause
speaker protection sometimes malfuctions

Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
Signed-off-by: Shenghao Ding <[email protected]>

---
v3:
- Add a bit more info desciption
- No blank line between Fixes and Singed-off-by tags
- https://lore.kernel.org/all/[email protected]/
---
sound/pci/hda/tas2781_hda_i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 48dae3339305..75f7674c66ee 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -514,10 +514,10 @@ static int tas2563_save_calibration(struct tasdevice_priv *tas_priv)
static void tas2781_apply_calib(struct tasdevice_priv *tas_priv)
{
static const unsigned char page_array[CALIB_MAX] = {
- 0x17, 0x18, 0x18, 0x0d, 0x18
+ 0x17, 0x18, 0x18, 0x13, 0x18,
};
static const unsigned char rgno_array[CALIB_MAX] = {
- 0x74, 0x0c, 0x14, 0x3c, 0x7c
+ 0x74, 0x0c, 0x14, 0x70, 0x7c,
};
unsigned char *data;
int i, j, rc;
--
2.34.1

2024-04-07 06:32:48

by Takashi Iwai

Subject: Re: [PATCH v3] ALSA: hda/tas2781: correct the register for pow calibrated data

On Sat, 06 Apr 2024 15:20:09 +0200,
Shenghao Ding wrote:
>
> Calibrated data was written into an incorrect register, which cause
> speaker protection sometimes malfuctions
>
> Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
> Signed-off-by: Shenghao Ding <[email protected]>

Thanks, applied now.


Takashi