2024-04-09 03:10:24

by Chen Ni

Subject: [PATCH] soc: fsl: qe: Add check for platform_driver_register

Return platform_driver_register() in order to transfer the error if
it fails.

Fixes: be7ecbd240b2 ("soc: fsl: qe: convert QE interrupt controller to platform_device")
Signed-off-by: Chen Ni <[email protected]>
---
drivers/soc/fsl/qe/qe_ic.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
index bbae3d39c7be..f17de6000ff2 100644
--- a/drivers/soc/fsl/qe/qe_ic.c
+++ b/drivers/soc/fsl/qe/qe_ic.c
@@ -481,7 +481,6 @@ static struct platform_driver qe_ic_driver =

static int __init qe_ic_of_init(void)
{
- platform_driver_register(&qe_ic_driver);
- return 0;
+ return platform_driver_register(&qe_ic_driver);
}
subsys_initcall(qe_ic_of_init);
--
2.25.1

2024-04-09 05:48:14

by Maxim Kochetkov

Subject: Re: [PATCH] soc: fsl: qe: Add check for platform_driver_register

09.04.2024 06:08, Chen Ni пишет:
> Return platform_driver_register() in order to transfer the error if
> it fails.
>
> Fixes: be7ecbd240b2 ("soc: fsl: qe: convert QE interrupt controller to platform_device")
> Signed-off-by: Chen Ni <[email protected]>

Reviewed-by: Maxim Kochetkov <[email protected]>