Subject: [PATCH] usb: typec: mux: it5205: Fix ChipID value typo

The ChipID bytes are read in inverse order: invert the ChipID value
defined as IT5205FN_CHIP_ID and used for validating the same.

Fixes: 41fe9ea1696c ("usb: typec: mux: Add ITE IT5205 Alternate Mode Passive MUX driver")
Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
---
drivers/usb/typec/mux/it5205.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c
index 5535932e42cd..4357cc67a867 100644
--- a/drivers/usb/typec/mux/it5205.c
+++ b/drivers/usb/typec/mux/it5205.c
@@ -22,7 +22,7 @@
#include <linux/usb/typec_mux.h>

#define IT5205_REG_CHIP_ID(x) (0x4 + (x))
-#define IT5205FN_CHIP_ID 0x35323035 /* "5205" */
+#define IT5205FN_CHIP_ID 0x35303235 /* "5025" -> "5205" */

/* MUX power down register */
#define IT5205_REG_MUXPDR 0x10
--
2.44.0



2024-04-15 14:12:41

by Heikki Krogerus

[permalink] [raw]
Subject: Re: [PATCH] usb: typec: mux: it5205: Fix ChipID value typo

On Tue, Apr 09, 2024 at 01:36:46PM +0200, AngeloGioacchino Del Regno wrote:
> The ChipID bytes are read in inverse order: invert the ChipID value
> defined as IT5205FN_CHIP_ID and used for validating the same.
>
> Fixes: 41fe9ea1696c ("usb: typec: mux: Add ITE IT5205 Alternate Mode Passive MUX driver")
> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>

Acked-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/mux/it5205.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c
> index 5535932e42cd..4357cc67a867 100644
> --- a/drivers/usb/typec/mux/it5205.c
> +++ b/drivers/usb/typec/mux/it5205.c
> @@ -22,7 +22,7 @@
> #include <linux/usb/typec_mux.h>
>
> #define IT5205_REG_CHIP_ID(x) (0x4 + (x))
> -#define IT5205FN_CHIP_ID 0x35323035 /* "5205" */
> +#define IT5205FN_CHIP_ID 0x35303235 /* "5025" -> "5205" */
>
> /* MUX power down register */
> #define IT5205_REG_MUXPDR 0x10
> --
> 2.44.0

--
heikki