The regulators' node names for mt6360-regulator are supposed to be
uppercase. Also, drop "-regulator" from the usb-otg-vbus node name
to make all vregs to probe correctly.
The alternative would've been to use regulator-compatible, but that's
a deprecated property.
Now all regulators are probing fine.
Fixes: 96564b1e2ea4 ("arm64: dts: mediatek: Introduce the MT8395 Radxa NIO 12L board")
Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
---
.../boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index e5d9b671a405..18182cf073fb 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -216,7 +216,7 @@ charger {
compatible = "mediatek,mt6360-chg";
richtek,vinovp-microvolt = <14500000>;
- otg_vbus_regulator: usb-otg-vbus-regulator {
+ otg_vbus_regulator: usb-otg-vbus {
regulator-name = "usb-otg-vbus";
regulator-min-microvolt = <4425000>;
regulator-max-microvolt = <5825000>;
@@ -228,7 +228,7 @@ regulator {
LDO_VIN1-supply = <&vsys_buck>;
LDO_VIN3-supply = <&mt6360_buck2>;
- mt6360_buck1: buck1 {
+ mt6360_buck1: BUCK1 {
regulator-name = "emi_vdd2";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1300000>;
@@ -238,7 +238,7 @@ MT6360_OPMODE_LP
regulator-always-on;
};
- mt6360_buck2: buck2 {
+ mt6360_buck2: BUCK2 {
regulator-name = "emi_vddq";
regulator-min-microvolt = <300000>;
regulator-max-microvolt = <1300000>;
@@ -248,7 +248,7 @@ MT6360_OPMODE_LP
regulator-always-on;
};
- mt6360_ldo1: ldo1 {
+ mt6360_ldo1: LDO1 {
regulator-name = "ext_lcd_3v3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
@@ -257,7 +257,7 @@ mt6360_ldo1: ldo1 {
regulator-always-on;
};
- mt6360_ldo2: ldo2 {
+ mt6360_ldo2: LDO2 {
regulator-name = "panel1_p1v8";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
@@ -265,7 +265,7 @@ mt6360_ldo2: ldo2 {
MT6360_OPMODE_LP>;
};
- mt6360_ldo3: ldo3 {
+ mt6360_ldo3: LDO3 {
regulator-name = "vmc_pmu";
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <3600000>;
@@ -273,7 +273,7 @@ mt6360_ldo3: ldo3 {
MT6360_OPMODE_LP>;
};
- mt6360_ldo5: ldo5 {
+ mt6360_ldo5: LDO5 {
regulator-name = "vmch_pmu";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
@@ -282,7 +282,7 @@ mt6360_ldo5: ldo5 {
regulator-always-on;
};
- mt6360_ldo6: ldo6 {
+ mt6360_ldo6: LDO6 {
regulator-name = "mt6360_ldo6"; /* Test point */
regulator-min-microvolt = <500000>;
regulator-max-microvolt = <2100000>;
@@ -290,7 +290,7 @@ mt6360_ldo6: ldo6 {
MT6360_OPMODE_LP>;
};
- mt6360_ldo7: ldo7 {
+ mt6360_ldo7: LDO7 {
regulator-name = "emi_vmddr_en";
regulator-min-microvolt = <500000>;
regulator-max-microvolt = <2100000>;
--
2.44.0
Il 09/04/24 13:42, AngeloGioacchino Del Regno ha scritto:
> The regulators' node names for mt6360-regulator are supposed to be
> uppercase. Also, drop "-regulator" from the usb-otg-vbus node name
> to make all vregs to probe correctly.
>
> The alternative would've been to use regulator-compatible, but that's
> a deprecated property.
> Now all regulators are probing fine.
>
> Fixes: 96564b1e2ea4 ("arm64: dts: mediatek: Introduce the MT8395 Radxa NIO 12L board")
> Signed-off-by: AngeloGioacchino Del Regno <[email protected]>
> ---
> .../boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
> index e5d9b671a405..18182cf073fb 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
> @@ -216,7 +216,7 @@ charger {
> compatible = "mediatek,mt6360-chg";
> richtek,vinovp-microvolt = <14500000>;
>
> - otg_vbus_regulator: usb-otg-vbus-regulator {
> + otg_vbus_regulator: usb-otg-vbus {
Reviewing and NACK'ing my own patch, I just noticed that everything apart the
usb-otg-vbus renaming is wrong.
The MT6360 regulator node names should not be capitalized as the bindings are
correct in this regard, and there already is one user (genio-1200-evk) apart
from NIO-12L declaring the wrong ones - so, the driver must be fixed, not the
other way around.
This patch will be cleaned up in v2.
Cheers