2024-04-09 19:21:20

by Francesco Dolcini

Subject: [PATCH v1] usb: typec: mux: gpio-sbu: Allow GPIO operations to sleep

From: Francesco Dolcini <[email protected]>

Use gpiod_set_value_cansleep() to support gpiochips which can
sleep like, e.g. I2C GPIO expanders.

Signed-off-by: Francesco Dolcini <[email protected]>
---
drivers/usb/typec/mux/gpio-sbu-mux.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c
index ad60fd4e8431..374168482d36 100644
--- a/drivers/usb/typec/mux/gpio-sbu-mux.c
+++ b/drivers/usb/typec/mux/gpio-sbu-mux.c
@@ -48,10 +48,10 @@ static int gpio_sbu_switch_set(struct typec_switch_dev *sw,
}

if (enabled != sbu_mux->enabled)
- gpiod_set_value(sbu_mux->enable_gpio, enabled);
+ gpiod_set_value_cansleep(sbu_mux->enable_gpio, enabled);

if (swapped != sbu_mux->swapped)
- gpiod_set_value(sbu_mux->select_gpio, swapped);
+ gpiod_set_value_cansleep(sbu_mux->select_gpio, swapped);

sbu_mux->enabled = enabled;
sbu_mux->swapped = swapped;
@@ -82,7 +82,7 @@ static int gpio_sbu_mux_set(struct typec_mux_dev *mux,
break;
}

- gpiod_set_value(sbu_mux->enable_gpio, sbu_mux->enabled);
+ gpiod_set_value_cansleep(sbu_mux->enable_gpio, sbu_mux->enabled);

mutex_unlock(&sbu_mux->lock);

@@ -141,7 +141,7 @@ static void gpio_sbu_mux_remove(struct platform_device *pdev)
{
struct gpio_sbu_mux *sbu_mux = platform_get_drvdata(pdev);

- gpiod_set_value(sbu_mux->enable_gpio, 0);
+ gpiod_set_value_cansleep(sbu_mux->enable_gpio, 0);

typec_mux_unregister(sbu_mux->mux);
typec_switch_unregister(sbu_mux->sw);
--
2.39.2

2024-04-09 23:01:24

by Dmitry Baryshkov

Subject: Re: [PATCH v1] usb: typec: mux: gpio-sbu: Allow GPIO operations to sleep

On Tue, Apr 09, 2024 at 09:09:10PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <[email protected]>
>
> Use gpiod_set_value_cansleep() to support gpiochips which can
> sleep like, e.g. I2C GPIO expanders.
>
> Signed-off-by: Francesco Dolcini <[email protected]>
> ---
> drivers/usb/typec/mux/gpio-sbu-mux.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Dmitry Baryshkov <[email protected]>

>

--
With best wishes
Dmitry

2024-04-15 11:41:59

by Heikki Krogerus

Subject: Re: [PATCH v1] usb: typec: mux: gpio-sbu: Allow GPIO operations to sleep

On Tue, Apr 09, 2024 at 09:09:10PM +0200, Francesco Dolcini wrote:
> From: Francesco Dolcini <[email protected]>
>
> Use gpiod_set_value_cansleep() to support gpiochips which can
> sleep like, e.g. I2C GPIO expanders.
>
> Signed-off-by: Francesco Dolcini <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/mux/gpio-sbu-mux.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/mux/gpio-sbu-mux.c b/drivers/usb/typec/mux/gpio-sbu-mux.c
> index ad60fd4e8431..374168482d36 100644
> --- a/drivers/usb/typec/mux/gpio-sbu-mux.c
> +++ b/drivers/usb/typec/mux/gpio-sbu-mux.c
> @@ -48,10 +48,10 @@ static int gpio_sbu_switch_set(struct typec_switch_dev *sw,
> }
>
> if (enabled != sbu_mux->enabled)
> - gpiod_set_value(sbu_mux->enable_gpio, enabled);
> + gpiod_set_value_cansleep(sbu_mux->enable_gpio, enabled);
>
> if (swapped != sbu_mux->swapped)
> - gpiod_set_value(sbu_mux->select_gpio, swapped);
> + gpiod_set_value_cansleep(sbu_mux->select_gpio, swapped);
>
> sbu_mux->enabled = enabled;
> sbu_mux->swapped = swapped;
> @@ -82,7 +82,7 @@ static int gpio_sbu_mux_set(struct typec_mux_dev *mux,
> break;
> }
>
> - gpiod_set_value(sbu_mux->enable_gpio, sbu_mux->enabled);
> + gpiod_set_value_cansleep(sbu_mux->enable_gpio, sbu_mux->enabled);
>
> mutex_unlock(&sbu_mux->lock);
>
> @@ -141,7 +141,7 @@ static void gpio_sbu_mux_remove(struct platform_device *pdev)
> {
> struct gpio_sbu_mux *sbu_mux = platform_get_drvdata(pdev);
>
> - gpiod_set_value(sbu_mux->enable_gpio, 0);
> + gpiod_set_value_cansleep(sbu_mux->enable_gpio, 0);
>
> typec_mux_unregister(sbu_mux->mux);
> typec_switch_unregister(sbu_mux->sw);
> --
> 2.39.2

--
heikki