The IOMMU hardware cache needs to be invalidated whenever the mappings
in the domain are changed. Currently, domain cache invalidation is
scattered across different places, causing several issues:
- IOMMU IOTLB Invalidation: This is done by iterating through the domain
IDs of each domain using the following code:
xa_for_each(&dmar_domain->iommu_array, i, info)
iommu_flush_iotlb_psi(info->iommu, dmar_domain,
start_pfn, nrpages,
list_empty(&gather->freelist), 0);
This code could theoretically cause a use-after-free problem because
there's no lock to protect the "info" pointer within the loop.
- Inconsistent Invalidation Methods: Different domain types implement
their own cache invalidation methods, making the code difficult to
maintain. For example, the DMA domain, SVA domain, and nested domain
have similar cache invalidation code scattered across different files.
- SVA Domain Inconsistency: The SVA domain implementation uses a
completely different data structure to track attached devices compared
to other domains. This creates unnecessary differences and, even
worse, leads to duplicate IOTLB invalidation when an SVA domain is
attached to devices belonging to a same IOMMU.
- Nested Domain Dependency: The special overlap between a nested domain
and its parent domain requires a dedicated parent_domain_flush()
helper function to be called everywhere the parent domain's mapping
changes.
- Limited Debugging Support: There are currently no debugging aids
available for domain cache invalidation.
By consolidating domain cache invalidation into a common location, we
can address the issues mentioned above and improve the code's
maintainability and debuggability.
The series and related patches are available on GitHub:
https://github.com/LuBaolu/intel-iommu/commits/iommu-vtd-cache-tag-v2
Change log:
v2:
- Allow cache tags of parent_type to be reusable.
- Save the the iommu device pointer to @dev of IOTLB tag type to make
it present the location of the TLB explicitly.
- Rename cache_tag_flush_cm_range() to cache_tag_flush_range_pt() to
make it clear that cache_tag_flush_range_pt() is called for PTEs
changes from non-present to present.
- Split out a patch series to clean up all inconsistent devtlb
invalidation policies for caching mode.
https://lore.kernel.org/linux-iommu/[email protected]/
- Fix a bug in intel_nested_cache_invalidate_user() where the @nrpages
is misused as @end.
- Various mics refinements and adjustments.
v1: https://lore.kernel.org/linux-iommu/[email protected]/
Jason Gunthorpe (1):
iommu: Add ops->domain_alloc_sva()
Lu Baolu (11):
iommu/vt-d: Add cache tag assignment interface
iommu/vt-d: Add cache tag invalidation helpers
iommu/vt-d: Add trace events for cache tag interface
iommu/vt-d: Use cache_tag_flush_all() in flush_iotlb_all
iommu/vt-d: Use cache_tag_flush_range() in tlb_sync
iommu/vt-d: Use cache_tag_flush_range_np() in iotlb_sync_map
iommu/vt-d: Cleanup use of iommu_flush_iotlb_psi()
iommu/vt-d: Use cache_tag_flush_range() in cache_invalidate_user
iommu/vt-d: Use cache helpers in arch_invalidate_secondary_tlbs
iommu/vt-d: Retire intel_svm_dev
iommu/vt-d: Retire struct intel_svm
include/linux/iommu.h | 3 +
drivers/iommu/intel/iommu.h | 79 ++++---
drivers/iommu/intel/trace.h | 97 +++++++++
drivers/iommu/intel/cache.c | 401 +++++++++++++++++++++++++++++++++++
drivers/iommu/intel/iommu.c | 296 ++++----------------------
drivers/iommu/intel/nested.c | 71 ++-----
drivers/iommu/intel/svm.c | 279 +++++-------------------
drivers/iommu/iommu-sva.c | 16 +-
drivers/iommu/intel/Makefile | 2 +-
9 files changed, 685 insertions(+), 559 deletions(-)
create mode 100644 drivers/iommu/intel/cache.c
--
2.34.1