2024-04-10 06:26:32

by Michael Opdenacker

Subject: [PATCH v3 1/2] dt-bindings: riscv: add Milk-V Duo S board compatibles

From: Michael Opdenacker <[email protected]>

Document the compatible strings for the Milk-V Duo S board[1] which uses
the SOPHGO SG2000 SoC, compatible with the SOPHGO CV1800B SoC[2].

Link: https://milkv.io/duo-s [1]
Link: https://en.sophgo.com/product/introduce/cv180xB.html [2]

Signed-off-by: Michael Opdenacker <[email protected]>
---
Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
index 9bc813dad098..1837bc550056 100644
--- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
+++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
@@ -21,6 +21,7 @@ properties:
- items:
- enum:
- milkv,duo
+ - milkv,duos
- const: sophgo,cv1800b
- items:
- enum:
--
2.34.1

2024-04-10 07:20:35

by Inochi Amaoto

Subject: Re: [PATCH v3 1/2] dt-bindings: riscv: add Milk-V Duo S board compatibles

On Wed, Apr 10, 2024 at 08:22:53AM +0200, [email protected] wrote:
> From: Michael Opdenacker <[email protected]>
>
> Document the compatible strings for the Milk-V Duo S board[1] which uses
> the SOPHGO SG2000 SoC, compatible with the SOPHGO CV1800B SoC[2].
>
> Link: https://milkv.io/duo-s [1]
> Link: https://en.sophgo.com/product/introduce/cv180xB.html [2]
>
> Signed-off-by: Michael Opdenacker <[email protected]>
> ---
> Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> index 9bc813dad098..1837bc550056 100644
> --- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
> +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> @@ -21,6 +21,7 @@ properties:
> - items:
> - enum:
> - milkv,duo
> + - milkv,duos
> - const: sophgo,cv1800b

Why not adding sg2000 property? They are different series.
IIRC, it at least a cv1813h not cv1800b. I suggest checking
the vendor SDK to get the right board compatibles.

> - items:
> - enum:
> --
> 2.34.1
>

2024-04-10 08:01:50

by Michael Opdenacker

Subject: Re: [PATCH v3 1/2] dt-bindings: riscv: add Milk-V Duo S board compatibles

Hi Inochi

Thanks for the reviews!

On 4/10/24 at 09:19, Inochi Amaoto wrote:
> On Wed, Apr 10, 2024 at 08:22:53AM +0200, [email protected] wrote:
>> From: Michael Opdenacker <[email protected]>
>>
>> Document the compatible strings for the Milk-V Duo S board[1] which uses
>> the SOPHGO SG2000 SoC, compatible with the SOPHGO CV1800B SoC[2].
>>
>> Link: https://milkv.io/duo-s [1]
>> Link: https://en.sophgo.com/product/introduce/cv180xB.html [2]
>>
>> Signed-off-by: Michael Opdenacker <[email protected]>
>> ---
>> Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
>> index 9bc813dad098..1837bc550056 100644
>> --- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
>> +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
>> @@ -21,6 +21,7 @@ properties:
>> - items:
>> - enum:
>> - milkv,duo
>> + - milkv,duos
>> - const: sophgo,cv1800b
> Why not adding sg2000 property? They are different series.
> IIRC, it at least a cv1813h not cv1800b. I suggest checking
> the vendor SDK to get the right board compatibles.

Here's what there was in the vendor provided DTB, if I noted it correctly:
compatible = "cvitek,cv181x";

Cheers
Michael

--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2024-04-10 10:17:29

by Inochi Amaoto

Subject: Re: [PATCH v3 1/2] dt-bindings: riscv: add Milk-V Duo S board compatibles

On Wed, Apr 10, 2024 at 09:55:17AM +0200, Michael Opdenacker wrote:
> Hi Inochi
>
> Thanks for the reviews!
>
> On 4/10/24 at 09:19, Inochi Amaoto wrote:
> > On Wed, Apr 10, 2024 at 08:22:53AM +0200, [email protected] wrote:
> > > From: Michael Opdenacker <[email protected]>
> > >
> > > Document the compatible strings for the Milk-V Duo S board[1] which uses
> > > the SOPHGO SG2000 SoC, compatible with the SOPHGO CV1800B SoC[2].
> > >
> > > Link: https://milkv.io/duo-s [1]
> > > Link: https://en.sophgo.com/product/introduce/cv180xB.html [2]
> > >
> > > Signed-off-by: Michael Opdenacker <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > index 9bc813dad098..1837bc550056 100644
> > > --- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > @@ -21,6 +21,7 @@ properties:
> > > - items:
> > > - enum:
> > > - milkv,duo
> > > + - milkv,duos
> > > - const: sophgo,cv1800b
> > Why not adding sg2000 property? They are different series.
> > IIRC, it at least a cv1813h not cv1800b. I suggest checking
> > the vendor SDK to get the right board compatibles.
>
> Here's what there was in the vendor provided DTB, if I noted it correctly:
> compatible = "cvitek,cv181x";
>
> Cheers
> Michael

That's true, the chipcode can be only see in the build script or
the board dts. You can use this as a base. For example, sg2000
can be something like: "sophgo,sg2000", "sophgo,cv1813h".
But in fact, I do not prefer to add "sophgo,cv1813h". Because
sg2000 can also boot as an aarch64 board, but cv1813h can't.