2024-04-10 22:51:15

by Thomas Gleixner

Subject: [patch V2 24/50] signal: Replace BUG_ON()s

These really can be handled gracefully without killing the machine.

Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Frederic Weisbecker <[email protected]>
---
kernel/signal.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1940,10 +1940,11 @@ struct sigqueue *sigqueue_alloc(void)

void sigqueue_free(struct sigqueue *q)
{
- unsigned long flags;
spinlock_t *lock = &current->sighand->siglock;
+ unsigned long flags;

- BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));
+ if (WARN_ON_ONCE(!(q->flags & SIGQUEUE_PREALLOC)))
+ return;
/*
* We must hold ->siglock while testing q->list
* to serialize with collect_signal() or with
@@ -1971,7 +1972,10 @@ int send_sigqueue(struct sigqueue *q, st
unsigned long flags;
int ret, result;

- BUG_ON(!(q->flags & SIGQUEUE_PREALLOC));
+ if (WARN_ON_ONCE(!(q->flags & SIGQUEUE_PREALLOC)))
+ return 0;
+ if (WARN_ON_ONCE(q->info.si_code != SI_TIMER))
+ return 0;

ret = -1;
rcu_read_lock();
@@ -2006,7 +2010,6 @@ int send_sigqueue(struct sigqueue *q, st
* If an SI_TIMER entry is already queue just increment
* the overrun count.
*/
- BUG_ON(q->info.si_code != SI_TIMER);
q->info.si_overrun++;
result = TRACE_SIGNAL_ALREADY_PENDING;
goto out;

2024-04-18 15:06:11

by Oleg Nesterov

Subject: Re: [patch V2 24/50] signal: Replace BUG_ON()s

On 04/11, Thomas Gleixner wrote:
>
> These really can be handled gracefully without killing the machine.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Reviewed-by: Frederic Weisbecker <[email protected]>
> ---
> kernel/signal.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)

Reviewed-by: Oleg Nesterov <[email protected]>