The binding reference common cdns-pcie-host.yaml, which already defines
msi-parent and has a reference to pci-bus.yaml schema. Drop redundant
pieces here to make it a bit smaller.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
index bc3c48f60fff..a8190d9b100f 100644
--- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
+++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml
@@ -10,7 +10,6 @@ maintainers:
- Tom Joseph <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
- $ref: cdns-pcie-host.yaml#
properties:
@@ -25,8 +24,6 @@ properties:
- const: reg
- const: cfg
- msi-parent: true
-
required:
- reg
- reg-names
--
2.34.1
MT7621 PCI host bridge has children which apparently are also PCI host
bridges, at least that's what the binding suggest. The children have
"reg" property, but do not explicitly define it. Instead they rely on
pci-bus.yaml schema, but that one has "reg" without any constraints.
Define the "reg" for the children, so the binding will be more specific
and later will allow dropping reference to deprecated pci-bus.yaml
schema.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
index e63e6458cea8..61d027239910 100644
--- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
@@ -36,6 +36,9 @@ patternProperties:
$ref: /schemas/pci/pci-bus.yaml#
properties:
+ reg:
+ maxItems: 1
+
resets:
maxItems: 1
--
2.34.1
dtschema package with core schemas deprecated pci-bus.yaml schema in
favor of pci-host-bridge.yaml. Update all bindings to use the latter
one.
The difference between pci-bus.yaml and pci-host-bridge.yaml is only in
lack of "reg" property defined by the latter, which should not have any
effect here, because all these bindings define the "reg".
The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml
binding which have children nodes being also host bridges, apparently.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/apple,pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml | 2 +-
Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 2 +-
Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +-
Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml | 2 +-
Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/loongson.yaml | 2 +-
.../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++--
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 2 +-
.../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 +-
Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 2 +-
Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +-
.../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +-
.../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +-
Documentation/devicetree/bindings/pci/versatile.yaml | 2 +-
Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +-
Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +-
Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +-
25 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
index a5bd90bc0712..79a21ba0f9fd 100644
--- a/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml
@@ -13,7 +13,7 @@ description:
Amlogic Meson PCIe host controller is based on the Synopsys DesignWare PCI core.
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- $ref: /schemas/pci/snps,dw-pcie-common.yaml#
# We need a select here so we don't match all nodes with 'snps,dw-pcie'
diff --git a/Documentation/devicetree/bindings/pci/apple,pcie.yaml b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
index 215ff9a9c835..c8775f9cb071 100644
--- a/Documentation/devicetree/bindings/pci/apple,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/apple,pcie.yaml
@@ -85,7 +85,7 @@ required:
unevaluatedProperties: false
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- $ref: /schemas/interrupt-controller/msi-controller.yaml#
- if:
properties:
diff --git a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
index 0e07ab61a48d..5434c144d2ec 100644
--- a/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml
@@ -11,7 +11,7 @@ maintainers:
- Scott Branden <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
index 22491f7f8852..11f8ea33240c 100644
--- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
@@ -108,7 +108,7 @@ required:
- msi-controller
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- $ref: /schemas/interrupt-controller/msi-controller.yaml#
- if:
properties:
diff --git a/Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml b/Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml
index a6b494401ebb..f4eb82e684bd 100644
--- a/Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml
+++ b/Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml
@@ -10,7 +10,7 @@ maintainers:
- Tom Joseph <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- $ref: cdns-pcie.yaml#
properties:
diff --git a/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml b/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml
index 92efbf0f1297..378dd1c8e2ee 100644
--- a/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml
+++ b/Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml
@@ -51,7 +51,7 @@ description: |
<0x6000 0 0 4 &pci_intc 2>;
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
index d25423aa7167..3484e0b4b412 100644
--- a/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
+++ b/Documentation/devicetree/bindings/pci/host-generic-pci.yaml
@@ -116,7 +116,7 @@ required:
- ranges
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- if:
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml b/Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml
index debfb54a8042..3cae2e0f7f5e 100644
--- a/Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml
+++ b/Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml
@@ -12,7 +12,7 @@ maintainers:
description: PCI host controller found in the Intel IXP4xx SoC series.
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml b/Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml
index 505acc4f3efc..1fd557504b10 100644
--- a/Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml
@@ -11,7 +11,7 @@ maintainers:
- Srikanth Thokala <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/loongson.yaml b/Documentation/devicetree/bindings/pci/loongson.yaml
index a8324a9bd002..1988465e73a1 100644
--- a/Documentation/devicetree/bindings/pci/loongson.yaml
+++ b/Documentation/devicetree/bindings/pci/loongson.yaml
@@ -13,7 +13,7 @@ description: |+
PCI host controller found on Loongson PCHs and SoCs.
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
index 61d027239910..5bbb4a3f3dbd 100644
--- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
@@ -14,7 +14,7 @@ description: |+
with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
@@ -33,7 +33,7 @@ properties:
patternProperties:
'^pcie@[0-2],0$':
type: object
- $ref: /schemas/pci/pci-bus.yaml#
+ $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
reg:
diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
index 7e8c7a2a5f9b..76d742051f73 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
@@ -140,7 +140,7 @@ required:
- interrupt-controller
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- if:
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
index f7a3c2636355..a3c4ddc094aa 100644
--- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
+++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
@@ -10,7 +10,7 @@ maintainers:
- Daire McNamara <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- $ref: /schemas/interrupt-controller/msi-controller.yaml#
properties:
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml
index 0d1b23523f62..0a39bbfcb28b 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml
@@ -95,6 +95,6 @@ anyOf:
- msi-map
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
additionalProperties: true
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index cf9a6910b542..f867746b1ae5 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -130,7 +130,7 @@ anyOf:
- msi-map
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- if:
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
index b6a7cb32f61e..210c3f2bf94c 100644
--- a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
@@ -12,7 +12,7 @@ maintainers:
- Yoshihiro Shimoda <[email protected]>
allOf:
- - $ref: pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml b/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml
index 5a0d64d3ae6b..b288cdb1ec70 100644
--- a/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml
+++ b/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml
@@ -110,7 +110,7 @@ required:
- "#interrupt-cells"
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- if:
properties:
diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
index 002b728cbc71..720a5f945a4e 100644
--- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml
@@ -10,7 +10,7 @@ maintainers:
- Shawn Lin <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- $ref: rockchip,rk3399-pcie-common.yaml#
properties:
diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
index 022055edbf9e..548f59d76ef2 100644
--- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
@@ -23,7 +23,7 @@ select:
- compatible
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- $ref: /schemas/pci/snps,dw-pcie-common.yaml#
- if:
not:
diff --git a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
index a20dccbafd94..695e491b7b3b 100644
--- a/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml
@@ -11,7 +11,7 @@ maintainers:
- Kishon Vijay Abraham I <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/versatile.yaml b/Documentation/devicetree/bindings/pci/versatile.yaml
index 09748ef6b94f..294c7cd84b37 100644
--- a/Documentation/devicetree/bindings/pci/versatile.yaml
+++ b/Documentation/devicetree/bindings/pci/versatile.yaml
@@ -13,7 +13,7 @@ description: |+
PCI host controller found on the ARM Versatile PB board's FPGA.
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
index 4734be456bde..b75ceefa6f93 100644
--- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
+++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
@@ -10,7 +10,7 @@ maintainers:
- Bharat Kumar Gogada <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml
index 69b7decabd45..fb87b960a250 100644
--- a/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml
+++ b/Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml
@@ -10,7 +10,7 @@ maintainers:
- Thippeswamy Havalige <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
diff --git a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml
index 426f90a47f35..b0d07c71c1c0 100644
--- a/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml
@@ -10,7 +10,7 @@ maintainers:
- Thippeswamy Havalige <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
- $ref: /schemas/interrupt-controller/msi-controller.yaml#
properties:
diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
index 0aa00b8e49b3..2f59b3a73dd2 100644
--- a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
+++ b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
@@ -10,7 +10,7 @@ maintainers:
- Thippeswamy Havalige <[email protected]>
allOf:
- - $ref: /schemas/pci/pci-bus.yaml#
+ - $ref: /schemas/pci/pci-host-bridge.yaml#
properties:
compatible:
--
2.34.1
On Sun, Apr 7, 2024 at 12:20 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> MT7621 PCI host bridge has children which apparently are also PCI host
> bridges, at least that's what the binding suggest. The children have
> "reg" property, but do not explicitly define it. Instead they rely on
> pci-bus.yaml schema, but that one has "reg" without any constraints.
>
> Define the "reg" for the children, so the binding will be more specific
> and later will allow dropping reference to deprecated pci-bus.yaml
> schema.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 3 +++
> 1 file changed, 3 insertions(+)
Acked-by: Sergio Paracuellos <[email protected]>
Thanks,
Sergio Paracuellos
On Sun, Apr 7, 2024 at 12:20 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> dtschema package with core schemas deprecated pci-bus.yaml schema in
> favor of pci-host-bridge.yaml. Update all bindings to use the latter
> one.
>
> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in
> lack of "reg" property defined by the latter, which should not have any
> effect here, because all these bindings define the "reg".
>
> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml
> binding which have children nodes being also host bridges, apparently.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++--
Acked-by: Sergio Paracuellos <[email protected]>
Thanks,
Sergio Paracuellos
On Sun, Apr 7, 2024 at 12:20 PM Krzysztof Kozlowski
<[email protected]> wrote:
> dtschema package with core schemas deprecated pci-bus.yaml schema in
> favor of pci-host-bridge.yaml. Update all bindings to use the latter
> one.
>
> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in
> lack of "reg" property defined by the latter, which should not have any
> effect here, because all these bindings define the "reg".
>
> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml
> binding which have children nodes being also host bridges, apparently.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +-
> .../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +-
LGTM, so
Reviewed-by: Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Sun, 07 Apr 2024 12:19:58 +0200, Krzysztof Kozlowski wrote:
> The binding reference common cdns-pcie-host.yaml, which already defines
> msi-parent and has a reference to pci-bus.yaml schema. Drop redundant
> pieces here to make it a bit smaller.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/cdns,cdns-pcie-host.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
Acked-by: Rob Herring <[email protected]>
On Sun, 07 Apr 2024 12:19:59 +0200, Krzysztof Kozlowski wrote:
> MT7621 PCI host bridge has children which apparently are also PCI host
> bridges, at least that's what the binding suggest. The children have
> "reg" property, but do not explicitly define it. Instead they rely on
> pci-bus.yaml schema, but that one has "reg" without any constraints.
>
> Define the "reg" for the children, so the binding will be more specific
> and later will allow dropping reference to deprecated pci-bus.yaml
> schema.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <[email protected]>
On Sun, Apr 07, 2024 at 12:20:00PM +0200, Krzysztof Kozlowski wrote:
> dtschema package with core schemas deprecated pci-bus.yaml schema in
> favor of pci-host-bridge.yaml. Update all bindings to use the latter
> one.
>
> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in
> lack of "reg" property defined by the latter, which should not have any
> effect here, because all these bindings define the "reg".
>
> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml
> binding which have children nodes being also host bridges, apparently.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml | 2 +-
> Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 2 +-
> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +-
> Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml | 2 +-
> Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/loongson.yaml | 2 +-
> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++--
> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 2 +-
> .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 +-
> Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 2 +-
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +-
> .../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +-
> .../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +-
> Documentation/devicetree/bindings/pci/versatile.yaml | 2 +-
> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +-
> Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +-
> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +-
> 25 files changed, 26 insertions(+), 26 deletions(-)
> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> index 61d027239910..5bbb4a3f3dbd 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> @@ -14,7 +14,7 @@ description: |+
> with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
>
> allOf:
> - - $ref: /schemas/pci/pci-bus.yaml#
> + - $ref: /schemas/pci/pci-host-bridge.yaml#
>
> properties:
> compatible:
> @@ -33,7 +33,7 @@ properties:
> patternProperties:
> '^pcie@[0-2],0$':
> type: object
> - $ref: /schemas/pci/pci-bus.yaml#
> + $ref: /schemas/pci/pci-host-bridge.yaml#
I think this one should be pci-pci-bridge.yaml instead since it says
these are root ports and based on the unit-address here.
Rob
On Sun, Apr 07, 2024 at 12:20:00PM +0200, Krzysztof Kozlowski wrote:
> dtschema package with core schemas deprecated pci-bus.yaml schema in
> favor of pci-host-bridge.yaml. Update all bindings to use the latter
> one.
>
> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in
> lack of "reg" property defined by the latter, which should not have any
> effect here, because all these bindings define the "reg".
>
> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml
> binding which have children nodes being also host bridges, apparently.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml | 2 +-
> Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 2 +-
> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +-
> Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml | 2 +-
> Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/loongson.yaml | 2 +-
> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++--
> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 2 +-
> .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 +-
> Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 2 +-
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +-
> .../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +-
> .../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +-
> Documentation/devicetree/bindings/pci/versatile.yaml | 2 +-
> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +-
> Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +-
> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
> Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +-
> 25 files changed, 26 insertions(+), 26 deletions(-)
This implicitly bumps the minimum version for dtschema. That's fine, but
it should be explicit since we set it explicitly.
Rob
On 10/04/2024 19:48, Rob Herring wrote:
> On Sun, Apr 07, 2024 at 12:20:00PM +0200, Krzysztof Kozlowski wrote:
>> dtschema package with core schemas deprecated pci-bus.yaml schema in
>> favor of pci-host-bridge.yaml. Update all bindings to use the latter
>> one.
>>
>> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in
>> lack of "reg" property defined by the latter, which should not have any
>> effect here, because all these bindings define the "reg".
>>
>> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml
>> binding which have children nodes being also host bridges, apparently.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/loongson.yaml | 2 +-
>> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++--
>> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 2 +-
>> .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +-
>> .../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +-
>> .../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/versatile.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +-
>> 25 files changed, 26 insertions(+), 26 deletions(-)
>
>
>> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
>> index 61d027239910..5bbb4a3f3dbd 100644
>> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
>> @@ -14,7 +14,7 @@ description: |+
>> with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
>>
>> allOf:
>> - - $ref: /schemas/pci/pci-bus.yaml#
>> + - $ref: /schemas/pci/pci-host-bridge.yaml#
>>
>> properties:
>> compatible:
>> @@ -33,7 +33,7 @@ properties:
>> patternProperties:
>> '^pcie@[0-2],0$':
>> type: object
>> - $ref: /schemas/pci/pci-bus.yaml#
>> + $ref: /schemas/pci/pci-host-bridge.yaml#
>
> I think this one should be pci-pci-bridge.yaml instead since it says
> these are root ports and based on the unit-address here.
I was thinking about this as well, but pci-pci-bridge.yaml defines
compatible which is not present here at all. Since you suggest pci-pci,
I'll go with this and make it a separate patch for easier review.
Best regards,
Krzysztof
On Wed, Apr 10, 2024 at 1:00 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 10/04/2024 19:48, Rob Herring wrote:
> > On Sun, Apr 07, 2024 at 12:20:00PM +0200, Krzysztof Kozlowski wrote:
> >> dtschema package with core schemas deprecated pci-bus.yaml schema in
> >> favor of pci-host-bridge.yaml. Update all bindings to use the latter
> >> one.
> >>
> >> The difference between pci-bus.yaml and pci-host-bridge.yaml is only in
> >> lack of "reg" property defined by the latter, which should not have any
> >> effect here, because all these bindings define the "reg".
> >>
> >> The change is therefore quite trivial, except mediatek,mt7621-pcie.yaml
> >> binding which have children nodes being also host bridges, apparently.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >> ---
> >> Documentation/devicetree/bindings/pci/amlogic,axg-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/apple,pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/brcm,iproc-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/cdns-pcie-host.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/faraday,ftpci100.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/host-generic-pci.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/loongson.yaml | 2 +-
> >> .../devicetree/bindings/pci/mediatek,mt7621-pcie.yaml | 4 ++--
> >> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 2 +-
> >> .../devicetree/bindings/pci/microchip,pcie-host.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/rcar-pci-host.yaml | 2 +-
> >> .../devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml | 2 +-
> >> .../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/versatile.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
> >> Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +-
> >> 25 files changed, 26 insertions(+), 26 deletions(-)
> >
> >
> >> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> >> index 61d027239910..5bbb4a3f3dbd 100644
> >> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> >> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> >> @@ -14,7 +14,7 @@ description: |+
> >> with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
> >>
> >> allOf:
> >> - - $ref: /schemas/pci/pci-bus.yaml#
> >> + - $ref: /schemas/pci/pci-host-bridge.yaml#
> >>
> >> properties:
> >> compatible:
> >> @@ -33,7 +33,7 @@ properties:
> >> patternProperties:
> >> '^pcie@[0-2],0$':
> >> type: object
> >> - $ref: /schemas/pci/pci-bus.yaml#
> >> + $ref: /schemas/pci/pci-host-bridge.yaml#
> >
> > I think this one should be pci-pci-bridge.yaml instead since it says
> > these are root ports and based on the unit-address here.
>
> I was thinking about this as well, but pci-pci-bridge.yaml defines
> compatible which is not present here at all. Since you suggest pci-pci,
> I'll go with this and make it a separate patch for easier review.
This was my concern at first. It does define compatible, but it
doesn't require it. So I think we are fine.
Rob
On 10/04/2024 19:55, Rob Herring wrote:
>> .../devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/ti,am65-pci-host.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/versatile.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/xlnx,axi-pcie-host.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/xlnx,nwl-pcie.yaml | 2 +-
>> Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml | 2 +-
>> 25 files changed, 26 insertions(+), 26 deletions(-)
>
> This implicitly bumps the minimum version for dtschema. That's fine, but
> it should be explicit since we set it explicitly.
Right, I will mention that this requires 2024.02
Best regards,
Krzysztof