2024-04-09 08:28:09

by Jacobe Zang

Subject: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings

This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel
designed to work with the Khadas VIM3 and VIM3L Single Board Computers.

Signed-off-by: Jacobe Zang <[email protected]>
---
.../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
index f9160d7bac3ca..e194309f31b72 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
@@ -36,6 +36,8 @@ properties:
- jdi,fhd-r63452
# Khadas TS050 5" 1080x1920 LCD panel
- khadas,ts050
+ # Khadas NEW TS050 5" 1080x1920 LCD panel
+ - khadas,newts050
# Kingdisplay KD097D04 9.7" 1536x2048 TFT LCD panel
- kingdisplay,kd097d04
# LG ACX467AKM-7 4.95" 1080×1920 LCD Panel
--
2.34.1

2024-04-09 20:11:42

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings

On 09/04/2024 10:26, Jacobe Zang wrote:
> This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel
> designed to work with the Khadas VIM3 and VIM3L Single Board Computers.
>
> Signed-off-by: Jacobe Zang <[email protected]>
> ---
> .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index f9160d7bac3ca..e194309f31b72 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -36,6 +36,8 @@ properties:
> - jdi,fhd-r63452
> # Khadas TS050 5" 1080x1920 LCD panel
> - khadas,ts050
> + # Khadas NEW TS050 5" 1080x1920 LCD panel
> + - khadas,newts050

Keep things ordered.

Best regards,
Krzysztof

2024-04-10 04:22:52

by Christian Hewitt

Subject: Re: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings

> On 9 Apr 2024, at 12:26 PM, Jacobe Zang <[email protected]> wrote:
>
> This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel
> designed to work with the Khadas VIM3 and VIM3L Single Board Computers.
>
> Signed-off-by: Jacobe Zang <[email protected]>
> ---
> .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> index f9160d7bac3ca..e194309f31b72 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -36,6 +36,8 @@ properties:
> - jdi,fhd-r63452
> # Khadas TS050 5" 1080x1920 LCD panel
> - khadas,ts050
> + # Khadas NEW TS050 5" 1080x1920 LCD panel
> + - khadas,newts050

Products are only new until they are old. At some future point there will
inevitably be a third iteration requiring a ‘new new’ name. IMHO it would
be better to use something like khadas,ts050v2.

CH.

> # Kingdisplay KD097D04 9.7" 1536x2048 TFT LCD panel
> - kingdisplay,kd097d04
> # LG ACX467AKM-7 4.95" 1080×1920 LCD Panel
> --
> 2.34.1
>
>
> _______________________________________________
> linux-amlogic mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

2024-04-10 18:57:20

by Rob Herring

Subject: Re: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings

On Wed, Apr 10, 2024 at 08:22:25AM +0400, Christian Hewitt wrote:
> > On 9 Apr 2024, at 12:26 PM, Jacobe Zang <[email protected]> wrote:
> >
> > This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel
> > designed to work with the Khadas VIM3 and VIM3L Single Board Computers.
> >
> > Signed-off-by: Jacobe Zang <[email protected]>
> > ---
> > .../devicetree/bindings/display/panel/panel-simple-dsi.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > index f9160d7bac3ca..e194309f31b72 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> > @@ -36,6 +36,8 @@ properties:
> > - jdi,fhd-r63452
> > # Khadas TS050 5" 1080x1920 LCD panel
> > - khadas,ts050
> > + # Khadas NEW TS050 5" 1080x1920 LCD panel
> > + - khadas,newts050
>
> Products are only new until they are old. At some future point there will
> inevitably be a third iteration requiring a ‘new new’ name. IMHO it would
> be better to use something like khadas,ts050v2.

I only see patch 1, so the threading is messed up...

In any case, The commit message should say something about how they are
different? Is the new one not compatible with the old? That's what this
change tells me. Otherwise, it should have a fallback.

Rob