2024-04-11 09:06:01

by Colin Ian King

Subject: [PATCH][next] iommu/vt-d: remove redundant assignment to variable err

Variable err is being assigned a value that is never read. It is
either being re-assigned later on error exit paths, or never referenced
on the non-error path.

Cleans up clang scan build warning:
drivers/iommu/intel/dmar.c:1070:2: warning: Value stored to 'err' is
never read [deadcode.DeadStores]`

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/iommu/intel/dmar.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index 36d7427b1202..351be9455214 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -1067,7 +1067,6 @@ static int alloc_iommu(struct dmar_drhd_unit *drhd)
goto error_free_seq_id;
}

- err = -EINVAL;
if (!cap_sagaw(iommu->cap) &&
(!ecap_smts(iommu->ecap) || ecap_slts(iommu->ecap))) {
pr_info("%s: No supported address widths. Not attempting DMA translation.\n",
--
2.39.2

2024-04-24 03:47:29

by Baolu Lu

Subject: Re: [PATCH][next] iommu/vt-d: remove redundant assignment to variable err

On 4/11/24 5:05 PM, Colin Ian King wrote:
> Variable err is being assigned a value that is never read. It is
> either being re-assigned later on error exit paths, or never referenced
> on the non-error path.
>
> Cleans up clang scan build warning:
> drivers/iommu/intel/dmar.c:1070:2: warning: Value stored to 'err' is
> never read [deadcode.DeadStores]`
>
> Signed-off-by: Colin Ian King<[email protected]>
> ---
> drivers/iommu/intel/dmar.c | 1 -
> 1 file changed, 1 deletion(-)

Patch has been queued for iommu/vt-d.

Best regards,
baolu