2024-04-10 23:22:23

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 0/2] gpiolib: acpi: A couple of error checks amendmends

One error check is moved and one is dropped.
No functional changes intended.

Andy Shevchenko (2):
gpiolib: acpi: Remove never true check in acpi_get_gpiod_by_index()
gpiolib: acpi: Check for errors first in acpi_find_gpio()

drivers/gpio/gpiolib-acpi.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

--
2.43.0.rc1.1336.g36b5255a03ac



2024-04-11 13:37:49

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v1 0/2] gpiolib: acpi: A couple of error checks amendmends

On Thu, Apr 11, 2024 at 04:28:06PM +0300, Mika Westerberg wrote:
> On Wed, Apr 10, 2024 at 11:21:45PM +0300, Andy Shevchenko wrote:
> > One error check is moved and one is dropped.
> > No functional changes intended.
> >
> > Andy Shevchenko (2):
> > gpiolib: acpi: Remove never true check in acpi_get_gpiod_by_index()
> > gpiolib: acpi: Check for errors first in acpi_find_gpio()
>
> Both,
>
> Acked-by: Mika Westerberg <[email protected]>

Pushed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko



2024-04-11 15:35:26

by Mika Westerberg

[permalink] [raw]
Subject: Re: [PATCH v1 0/2] gpiolib: acpi: A couple of error checks amendmends

On Wed, Apr 10, 2024 at 11:21:45PM +0300, Andy Shevchenko wrote:
> One error check is moved and one is dropped.
> No functional changes intended.
>
> Andy Shevchenko (2):
> gpiolib: acpi: Remove never true check in acpi_get_gpiod_by_index()
> gpiolib: acpi: Check for errors first in acpi_find_gpio()

Both,

Acked-by: Mika Westerberg <[email protected]>