2024-04-12 05:05:21

by Prasad Pandit

[permalink] [raw]
Subject: [PATCH v1] misc: sgi_gru: indent SGI_GRU option help text

From: Prasad Pandit <[email protected]>

Fix indentation of SGI_GRU option's help text by adding
leading spaces. Generally help text is indented by couple
of spaces more beyond the leading tab <\t> character.
It helps Kconfig parsers to read file without error.

Signed-off-by: Prasad Pandit <[email protected]>
---
drivers/misc/Kconfig | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

v1:
- s/\t/ / at line #431
- CC public mailing list

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 4fb291f0bf7c..a6565c42a7b9 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -293,21 +293,21 @@ config SGI_GRU
depends on X86_UV && SMP
select MMU_NOTIFIER
help
- The GRU is a hardware resource located in the system chipset. The GRU
- contains memory that can be mmapped into the user address space. This memory is
- used to communicate with the GRU to perform functions such as load/store,
- scatter/gather, bcopy, AMOs, etc. The GRU is directly accessed by user
- instructions using user virtual addresses. GRU instructions (ex., bcopy) use
- user virtual addresses for operands.
+ The GRU is a hardware resource located in the system chipset. The GRU
+ contains memory that can be mmapped into the user address space.
+ This memory is used to communicate with the GRU to perform functions
+ such as load/store, scatter/gather, bcopy, AMOs, etc. The GRU is
+ directly accessed by user instructions using user virtual addresses.
+ GRU instructions (ex., bcopy) use user virtual addresses for operands.

- If you are not running on a SGI UV system, say N.
+ If you are not running on a SGI UV system, say N.

config SGI_GRU_DEBUG
bool "SGI GRU driver debug"
depends on SGI_GRU
help
- This option enables additional debugging code for the SGI GRU driver.
- If you are unsure, say N.
+ This option enables additional debugging code for the SGI GRU driver.
+ If you are unsure, say N.

config APDS9802ALS
tristate "Medfield Avago APDS9802 ALS Sensor module"
@@ -428,7 +428,7 @@ config LATTICE_ECP3_CONFIG
tristate "Lattice ECP3 FPGA bitstream configuration via SPI"
depends on SPI && SYSFS
select FW_LOADER
- default n
+ default n
help
This option enables support for bitstream configuration (programming
or loading) of the Lattice ECP3 FPGA family via SPI.
--
2.44.0



2024-04-12 05:09:37

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v1] misc: sgi_gru: indent SGI_GRU option help text

On Fri, Apr 12, 2024 at 10:35:02AM +0530, Prasad Pandit wrote:
> From: Prasad Pandit <[email protected]>
>
> Fix indentation of SGI_GRU option's help text by adding
> leading spaces. Generally help text is indented by couple
> of spaces more beyond the leading tab <\t> character.
> It helps Kconfig parsers to read file without error.
>
> Signed-off-by: Prasad Pandit <[email protected]>
> ---
> drivers/misc/Kconfig | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> v1:
> - s/\t/ / at line #431
> - CC public mailing list

v1 was the private version you sent, this is v2, right?




>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 4fb291f0bf7c..a6565c42a7b9 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -293,21 +293,21 @@ config SGI_GRU
> depends on X86_UV && SMP
> select MMU_NOTIFIER
> help
> - The GRU is a hardware resource located in the system chipset. The GRU
> - contains memory that can be mmapped into the user address space. This memory is
> - used to communicate with the GRU to perform functions such as load/store,
> - scatter/gather, bcopy, AMOs, etc. The GRU is directly accessed by user
> - instructions using user virtual addresses. GRU instructions (ex., bcopy) use
> - user virtual addresses for operands.
> + The GRU is a hardware resource located in the system chipset. The GRU
> + contains memory that can be mmapped into the user address space.
> + This memory is used to communicate with the GRU to perform functions
> + such as load/store, scatter/gather, bcopy, AMOs, etc. The GRU is
> + directly accessed by user instructions using user virtual addresses.
> + GRU instructions (ex., bcopy) use user virtual addresses for operands.
>
> - If you are not running on a SGI UV system, say N.
> + If you are not running on a SGI UV system, say N.
>
> config SGI_GRU_DEBUG
> bool "SGI GRU driver debug"
> depends on SGI_GRU
> help
> - This option enables additional debugging code for the SGI GRU driver.
> - If you are unsure, say N.
> + This option enables additional debugging code for the SGI GRU driver.
> + If you are unsure, say N.
>
> config APDS9802ALS
> tristate "Medfield Avago APDS9802 ALS Sensor module"
> @@ -428,7 +428,7 @@ config LATTICE_ECP3_CONFIG
> tristate "Lattice ECP3 FPGA bitstream configuration via SPI"
> depends on SPI && SYSFS
> select FW_LOADER
> - default n
> + default n

This line should just be deleted in a separate patch as it is the
default.

Can you do this as a patch series for v3 please?

thanks,

greg k-h

2024-04-12 05:22:37

by Prasad Pandit

[permalink] [raw]
Subject: Re: [PATCH v1] misc: sgi_gru: indent SGI_GRU option help text

On Friday, 12 April, 2024 at 10:39:40 am IST, Greg Kroah-Hartman wrote:
On Fri, Apr 12, 2024 at 10:35:02AM +0530, Prasad Pandit wrote:
>> v1:
>>  - s/\t/ / at line #431
>>  - CC public mailing list
>
>v1 was the private version you sent, this is v2, right?

>> -    default    n
>> +    default n
>
>This line should just be deleted in a separate patch as it is the default.
>Can you do this as a patch series for v3 please?

Okay. Thank you.
---
  -Prasad