2024-04-09 13:04:30

by Lizhe

Subject: [PATCH] cpufreq: pcc-cpufreq: Remove redundant exit() functions

The return value of exit() is 0 and it performs no action.
This function can be omitted. Please refer to the end condition
check in the __cpufreq_offline() function.

Signed-off-by: Lizhe <[email protected]>
---
drivers/cpufreq/pcc-cpufreq.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
index 6f8b5ea7aeae..771efbf51a48 100644
--- a/drivers/cpufreq/pcc-cpufreq.c
+++ b/drivers/cpufreq/pcc-cpufreq.c
@@ -562,18 +562,12 @@ static int pcc_cpufreq_cpu_init(struct cpufreq_policy *policy)
return result;
}

-static int pcc_cpufreq_cpu_exit(struct cpufreq_policy *policy)
-{
- return 0;
-}
-
static struct cpufreq_driver pcc_cpufreq_driver = {
.flags = CPUFREQ_CONST_LOOPS,
.get = pcc_get_freq,
.verify = pcc_cpufreq_verify,
.target = pcc_cpufreq_target,
.init = pcc_cpufreq_cpu_init,
- .exit = pcc_cpufreq_cpu_exit,
.name = "pcc-cpufreq",
};

--
2.25.1

2024-04-12 05:50:08

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: pcc-cpufreq: Remove redundant exit() functions

On 09-04-24, 05:50, Lizhe wrote:
> The return value of exit() is 0 and it performs no action.
> This function can be omitted. Please refer to the end condition
> check in the __cpufreq_offline() function.
>
> Signed-off-by: Lizhe <[email protected]>
> ---
> drivers/cpufreq/pcc-cpufreq.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c
> index 6f8b5ea7aeae..771efbf51a48 100644
> --- a/drivers/cpufreq/pcc-cpufreq.c
> +++ b/drivers/cpufreq/pcc-cpufreq.c
> @@ -562,18 +562,12 @@ static int pcc_cpufreq_cpu_init(struct cpufreq_policy *policy)
> return result;
> }
>
> -static int pcc_cpufreq_cpu_exit(struct cpufreq_policy *policy)
> -{
> - return 0;
> -}
> -
> static struct cpufreq_driver pcc_cpufreq_driver = {
> .flags = CPUFREQ_CONST_LOOPS,
> .get = pcc_get_freq,
> .verify = pcc_cpufreq_verify,
> .target = pcc_cpufreq_target,
> .init = pcc_cpufreq_cpu_init,
> - .exit = pcc_cpufreq_cpu_exit,
> .name = "pcc-cpufreq",
> };

Acked-by: Viresh Kumar <[email protected]>

--
viresh