2024-04-12 05:12:51

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the fpga tree

Hi all,

After merging the fpga tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/fpga/ice40-spi.c:201:35: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration]
201 | .of_match_table = of_match_ptr(ice40_fpga_of_match),
| ^~~~~~~~~~~~
drivers/fpga/ice40-spi.c:201:35: error: initialization of 'const struct of_device_id *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
drivers/fpga/ice40-spi.c:201:35: note: (near initialization for 'ice40_fpga_driver.driver.of_match_table')
drivers/fpga/ice40-spi.c:201:35: error: initializer element is not constant
drivers/fpga/ice40-spi.c:201:35: note: (near initialization for 'ice40_fpga_driver.driver.of_match_table')
cc1: all warnings being treated as errors

Caused by commit

5d04660b29fb ("fpga: ice40-spi: Remove unused of_gpio.h")

I have used the fpga tree from next-20240411 for today.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2024-04-12 15:27:42

by Andy Shevchenko

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the fpga tree

On Fri, Apr 12, 2024 at 03:11:47PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the fpga tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/fpga/ice40-spi.c:201:35: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration]
> 201 | .of_match_table = of_match_ptr(ice40_fpga_of_match),
> | ^~~~~~~~~~~~
> drivers/fpga/ice40-spi.c:201:35: error: initialization of 'const struct of_device_id *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> drivers/fpga/ice40-spi.c:201:35: note: (near initialization for 'ice40_fpga_driver.driver.of_match_table')
> drivers/fpga/ice40-spi.c:201:35: error: initializer element is not constant
> drivers/fpga/ice40-spi.c:201:35: note: (near initialization for 'ice40_fpga_driver.driver.of_match_table')
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> 5d04660b29fb ("fpga: ice40-spi: Remove unused of_gpio.h")
>
> I have used the fpga tree from next-20240411 for today.

Okay, thanks for the report. I'll send a fix soon.

--
With Best Regards,
Andy Shevchenko