2024-04-14 15:12:28

by Jonas Karlman

Subject: [PATCH v2 3/3] dt-bindings: display: rockchip,dw-hdmi: Fix sound-dai-cells warning

The rockchip,dw-hdmi node can be used as a sound dai codec, however,
dtbs_check may report the following issue:

hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected)
from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#

Add a reference to dai-common.yaml and add the #sound-dai-cells prop to
resolve this warning.

Signed-off-by: Jonas Karlman <[email protected]>
---
v2: New patch to fix #sound-dai-cells warning
---
.../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
index af638b6c0d21..3285fff54416 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
@@ -15,6 +15,7 @@ description: |

allOf:
- $ref: ../bridge/synopsys,dw-hdmi.yaml#
+ - $ref: /schemas/sound/dai-common.yaml#

properties:
compatible:
@@ -124,6 +125,9 @@ properties:
description:
phandle to the GRF to mux vopl/vopb.

+ "#sound-dai-cells":
+ const: 0
+
required:
- compatible
- reg
--
2.43.2

2024-04-14 18:54:19

by Jonas Karlman

Subject: Re: [PATCH v2 3/3] dt-bindings: display: rockchip,dw-hdmi: Fix sound-dai-cells warning

On 2024-04-14 20:41, Johan Jonker wrote:
> On 4/14/24 17:11, Jonas Karlman wrote:
>> The rockchip,dw-hdmi node can be used as a sound dai codec, however,
>> dtbs_check may report the following issue:
>>
>> hdmi@fe0a0000: Unevaluated properties are not allowed ('#sound-dai-cells' was unexpected)
>> from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#
>>
>> Add a reference to dai-common.yaml and add the #sound-dai-cells prop to
>> resolve this warning.
>>
>> Signed-off-by: Jonas Karlman <[email protected]>
>> ---
>
>> v2: New patch to fix #sound-dai-cells warning
>
> Hi,
>
> You are #4 that does an attempt on this subject.
> Coincidence with my patches??
> If other notifications could be fixed with the same amount of interest?
> Please be welcome to pick some other random Rockchip related ones.

Hehe, I should have looked deeper at what existing patches was out there.

Will send a v3 without this patch and instead reference your patch.

Regards,
Jonas

>
> Johan
>
> ===
>
> [PATCH v1 1/3] dt-bindings: display: add #sound-dai-cells property to rockchip dw hdmi
> https://lore.kernel.org/linux-rockchip/[email protected]/
>
> [PATCH] dt-bindings: display: rockchip: add missing #sound-dai-cells to dw-hdmi
> https://lore.kernel.org/linux-rockchip/[email protected]/
>
> [PATCH 6/6] dt-bindings: display: rockchip: dw-hdmi: Add missing sound-dai-cells property
> https://lore.kernel.org/linux-rockchip/[email protected]/
>
>> ---
>> .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
>> index af638b6c0d21..3285fff54416 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
>> @@ -15,6 +15,7 @@ description: |
>>
>> allOf:
>> - $ref: ../bridge/synopsys,dw-hdmi.yaml#
>> + - $ref: /schemas/sound/dai-common.yaml#
>>
>> properties:
>> compatible:
>> @@ -124,6 +125,9 @@ properties:
>> description:
>> phandle to the GRF to mux vopl/vopb.
>>
>> + "#sound-dai-cells":
>> + const: 0
>> +
>> required:
>> - compatible
>> - reg