2024-04-15 03:00:37

by Lei Chen

[permalink] [raw]
Subject: [PATCH v2] x86/tsc: print some log if calibrated tsc freq deviates from original too much

In most cases, tsc_khz is refined by hpet on boot. But in a few
production-level nodes, the refinement fails because calibrated
freq diviates from origin tsc freq more than 1%. Printing some
logs will help get this info.

Signed-off-by: Lei Chen <[email protected]>
Suggested-by: Ingo Molnar <[email protected]>

---
Changes from v1:
https://lore.kernel.org/all/[email protected]/
1. s/deviates too much from/deviates by more than 1%% from
2. Use pr_info instead of pr_warning

arch/x86/kernel/tsc.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 15f97c0abc9d..06c6583aa8fb 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -1435,8 +1435,15 @@ static void tsc_refine_calibration_work(struct work_struct *work)
}

/* Make sure we're within 1% */
- if (abs(tsc_khz - freq) > tsc_khz/100)
+ if (abs(tsc_khz - freq) > tsc_khz/100) {
+ pr_info("TSC freq calibrated by [%s]: %lu.%03lu MHz deviates by more than 1%% from original freq: %lu.%03lu MHz\n",
+ hpet ? "HPET" : "PM_TIMER",
+ (unsigned long)freq / 1000,
+ (unsigned long)freq % 1000,
+ (unsigned long)tsc_khz / 1000,
+ (unsigned long)tsc_khz % 1000);
goto out;
+ }

tsc_khz = freq;
pr_info("Refined TSC clocksource calibration: %lu.%03lu MHz\n",
--
2.44.0