The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.
/drivers/net/ipa/ipa_interrupt.c:300:2-9: line 300 is redundant because platform_get_irq() already prints an error.
Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8756
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/ipa/ipa_interrupt.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ipa/ipa_interrupt.c b/drivers/net/ipa/ipa_interrupt.c
index c3e8784d51d9..c44ec05f71e6 100644
--- a/drivers/net/ipa/ipa_interrupt.c
+++ b/drivers/net/ipa/ipa_interrupt.c
@@ -291,16 +291,12 @@ void ipa_interrupt_deconfig(struct ipa *ipa)
/* Initialize the IPA interrupt structure */
struct ipa_interrupt *ipa_interrupt_init(struct platform_device *pdev)
{
- struct device *dev = &pdev->dev;
struct ipa_interrupt *interrupt;
int irq;
irq = platform_get_irq_byname(pdev, "ipa");
- if (irq <= 0) {
- dev_err(dev, "DT error %d getting \"ipa\" IRQ property\n", irq);
-
+ if (irq <= 0)
return ERR_PTR(irq ? : -EINVAL);
- }
interrupt = kzalloc(sizeof(*interrupt), GFP_KERNEL);
if (!interrupt)
--
2.20.1.7.g153144c
On Mon, Apr 15, 2024 at 11:14:56AM +0800, Jiapeng Chong wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> ./drivers/net/ipa/ipa_interrupt.c:300:2-9: line 300 is redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8756
> Signed-off-by: Jiapeng Chong <[email protected]>
Hi Jiapeng Chong,
I don't think that you need to repost because of this,
but when sending Networking patches please specify the target tree
in the subject; net for fixes, and net-next for other patches.
e.g.
Subject: [PATCH net-next] ...
That notwithstanding, this patch looks good to me.
Reviewed-by: Simon Horman <[email protected]>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:
On Mon, 15 Apr 2024 11:14:56 +0800 you wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> ./drivers/net/ipa/ipa_interrupt.c:300:2-9: line 300 is redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8756
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]
Here is the summary with links:
- net: ipa: Remove unnecessary print function dev_err()
https://git.kernel.org/netdev/net-next/c/19ad0f3a16d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html