2024-04-16 10:51:39

by Viken Dadhaniya

Subject: [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node

Enable gpi-dma0, gpi-dma1 and qupv3_id_1 nodes for
busses usecase on RB3 platform.

Signed-off-by: Viken Dadhaniya <[email protected]>
---
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index c98c41f8f3b1..811033592bab 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -603,10 +603,22 @@
status = "okay";
};

+&gpi_dma0 {
+ status = "okay";
+};
+
+&gpi_dma1 {
+ status = "okay";
+};
+
&qupv3_id_0 {
status = "okay";
};

+&qupv3_id_1 {
+ status = "okay";
+};
+
&remoteproc_adsp {
firmware-name = "qcom/qcs6490/adsp.mbn";
status = "okay";
--
2.17.1

2024-04-16 12:33:01

by Dmitry Baryshkov

Subject: Re: [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node

On Tue, 16 Apr 2024 at 13:51, Viken Dadhaniya <[email protected]> wrote:
>
> Enable gpi-dma0, gpi-dma1 and qupv3_id_1 nodes for
> busses usecase on RB3 platform.
>
> Signed-off-by: Viken Dadhaniya <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)


Reviewed-by: Dmitry Baryshkov <[email protected]>


--
With best wishes
Dmitry

2024-04-16 12:34:39

by Dmitry Baryshkov

Subject: Re: [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node

On Tue, 16 Apr 2024 at 15:32, Dmitry Baryshkov
<[email protected]> wrote:
>
> On Tue, 16 Apr 2024 at 13:51, Viken Dadhaniya <[email protected]> wrote:
> >
> > Enable gpi-dma0, gpi-dma1 and qupv3_id_1 nodes for
> > busses usecase on RB3 platform.
> >
> > Signed-off-by: Viken Dadhaniya <[email protected]>
> > ---
> > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
>
>
> Reviewed-by: Dmitry Baryshkov <[email protected]>

Well, actually:

Unreviewed-by: Dmitry Baryshkov <[email protected]>

Please place the gpi_dmaN nodes where they belong rather than sticking
them right before the qup nodes. The file should be sorted.

--
With best wishes
Dmitry

2024-04-24 05:51:24

by Viken Dadhaniya

Subject: Re: [PATCH v1] arm64: dts: qcom: qcm6490-rb3: Enable gpi-dma and qup node

On 4/16/2024 6:04 PM, Dmitry Baryshkov wrote:
> On Tue, 16 Apr 2024 at 15:32, Dmitry Baryshkov
> <[email protected]> wrote:
>>
>> On Tue, 16 Apr 2024 at 13:51, Viken Dadhaniya <[email protected]> wrote:
>>>
>>> Enable gpi-dma0, gpi-dma1 and qupv3_id_1 nodes for
>>> busses usecase on RB3 platform.
>>>
>>> Signed-off-by: Viken Dadhaniya <[email protected]>
>>> ---
>>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>
>>
>> Reviewed-by: Dmitry Baryshkov <[email protected]>
>
> Well, actually:
>
> Unreviewed-by: Dmitry Baryshkov <[email protected]>
>
> Please place the gpi_dmaN nodes where they belong rather than sticking
> them right before the qup nodes. The file should be sorted.
>

Updated in v2.