2024-04-16 22:17:16

by Judith Mendez

[permalink] [raw]
Subject: [PATCH v2 6/6] arm64: defconfig: Set CONFIG_MFD_TPS6594_I2C=y

SK-AM62A-LP uses TPS6593x PMIC (interfaced over I2C) to power the SoC
and various other peripherals on the board [1].

Booting SD with UHS modes have a dependency on TPS6593x PMIC driver so
change to built in order to boot using SD boot at the higher speed modes.

Fixes: f9010eb938be ("arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A")
Signed-off-by: Judith Mendez <[email protected]>
---
Changes since v1:
- Add patch 6/6
---
arch/arm64/configs/defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 2c30d617e1802..c994ba7b682dd 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -741,7 +741,7 @@ CONFIG_MFD_SL28CPLD=y
CONFIG_RZ_MTU3=y
CONFIG_MFD_TI_AM335X_TSCADC=m
CONFIG_MFD_TPS65219=y
-CONFIG_MFD_TPS6594_I2C=m
+CONFIG_MFD_TPS6594_I2C=y
CONFIG_MFD_ROHM_BD718XX=y
CONFIG_MFD_WCD934X=m
CONFIG_MFD_KHADAS_MCU=m
--
2.43.2



2024-04-19 13:59:39

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 6/6] arm64: defconfig: Set CONFIG_MFD_TPS6594_I2C=y

On 17/04/2024 00:16, Judith Mendez wrote:
> SK-AM62A-LP uses TPS6593x PMIC (interfaced over I2C) to power the SoC
> and various other peripherals on the board [1].
>
> Booting SD with UHS modes have a dependency on TPS6593x PMIC driver so
> change to built in order to boot using SD boot at the higher speed modes.
>
> Fixes: f9010eb938be ("arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A")

No, that's not a fix. Fix is using proper initramfs, because bug is lack
of initramfs, not having it as module.

I don't agree, because I prefer to have this as module.

> Signed-off-by: Judith Mendez <[email protected]>


Best regards,
Krzysztof


2024-04-22 22:07:11

by Judith Mendez

[permalink] [raw]
Subject: Re: [PATCH v2 6/6] arm64: defconfig: Set CONFIG_MFD_TPS6594_I2C=y

Hi,

On 4/19/24 8:59 AM, Krzysztof Kozlowski wrote:
> On 17/04/2024 00:16, Judith Mendez wrote:
>> SK-AM62A-LP uses TPS6593x PMIC (interfaced over I2C) to power the SoC
>> and various other peripherals on the board [1].
>>
>> Booting SD with UHS modes have a dependency on TPS6593x PMIC driver so
>> change to built in order to boot using SD boot at the higher speed modes.
>>
>> Fixes: f9010eb938be ("arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A")
>
> No, that's not a fix. Fix is using proper initramfs, because bug is lack
> of initramfs, not having it as module.
>
> I don't agree, because I prefer to have this as module.

ok, will drop this patch, thanks.

~ Judith

>
>> Signed-off-by: Judith Mendez <[email protected]>
>
>
> Best regards,
> Krzysztof
>