2024-04-17 06:53:37

by Michael Opdenacker

Subject: [PATCH v5 1/2] dt-bindings: riscv: add Milk-V Duo S board compatibles

From: Michael Opdenacker <[email protected]>

Document the compatible strings for the Milk-V Duo S board[1] which uses
the SOPHGO SG2000 SoC, compatible with the SOPHGO CV1800B SoC[2].

Link: https://milkv.io/duo-s [1]
Link: https://en.sophgo.com/product/introduce/cv180xB.html [2]

Signed-off-by: Michael Opdenacker <[email protected]>
---
Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
index 9bc813dad098..1837bc550056 100644
--- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
+++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
@@ -21,6 +21,7 @@ properties:
- items:
- enum:
- milkv,duo
+ - milkv,duos
- const: sophgo,cv1800b
- items:
- enum:
--
2.34.1

2024-04-17 09:25:26

by Inochi Amaoto

Subject: Re: [PATCH v5 1/2] dt-bindings: riscv: add Milk-V Duo S board compatibles

On Wed, Apr 17, 2024 at 08:53:10AM GMT, [email protected] wrote:
> From: Michael Opdenacker <[email protected]>
>
> Document the compatible strings for the Milk-V Duo S board[1] which uses
> the SOPHGO SG2000 SoC, compatible with the SOPHGO CV1800B SoC[2].
>
> Link: https://milkv.io/duo-s [1]
> Link: https://en.sophgo.com/product/introduce/cv180xB.html [2]
>
> Signed-off-by: Michael Opdenacker <[email protected]>
> ---
> Documentation/devicetree/bindings/riscv/sophgo.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> index 9bc813dad098..1837bc550056 100644
> --- a/Documentation/devicetree/bindings/riscv/sophgo.yaml
> +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> @@ -21,6 +21,7 @@ properties:
> - items:
> - enum:
> - milkv,duo
> + - milkv,duos

Please ADD CPU COMPATIBLE, AND NOT JUST USE CV1800B.
I do not want to say this again.

> - const: sophgo,cv1800b
> - items:
> - enum:
> --
> 2.34.1
>