2024-04-18 06:38:53

by Dmitry Baryshkov

Subject: [PATCH v3] dt-bindings: usb: qcom,pmic-typec: update example to follow connector schema

Update Qualcomm PMIC Type-C examples to follow the USB-C connector
schema. The USB-C connector should have three ports (USB HS @0,
SSTX/RX @1 and SBU @2 lanes). Reorder ports accordingly and add SBU port
connected to the SBU mux (e.g. FSA4480).

Reported-by: Luca Weiss <[email protected]>
Acked-by: Konrad Dybcio <[email protected]>
Signed-off-by: Dmitry Baryshkov <[email protected]>
---
Update examples to follow usb-c-connector schema wrt. ports definitions.
---
Changes in v3:
- Dropped the Fixes tag (Greg, Conor)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Dropped patch removing the role-switching port. We do not use it, but
it can become useful by other designs.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
.../devicetree/bindings/usb/qcom,pmic-typec.yaml | 34 +++++++++++++++++-----
1 file changed, 26 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
index 0cdc60b76fbd..6d3ef364672e 100644
--- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
@@ -193,15 +193,22 @@ examples:

port@0 {
reg = <0>;
- pmic_typec_mux_out: endpoint {
- remote-endpoint = <&usb_phy_typec_mux_in>;
+ pmic_typec_hs_in: endpoint {
+ remote-endpoint = <&usb_hs_out>;
};
};

port@1 {
reg = <1>;
- pmic_typec_role_switch_out: endpoint {
- remote-endpoint = <&usb_role_switch_in>;
+ pmic_typec_ss_in: endpoint {
+ remote-endpoint = <&usb_phy_typec_ss_out>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+ pmic_typec_sbu: endpoint {
+ remote-endpoint = <&usb_mux_sbu>;
};
};
};
@@ -213,8 +220,8 @@ examples:
dr_mode = "otg";
usb-role-switch;
port {
- usb_role_switch_in: endpoint {
- remote-endpoint = <&pmic_typec_role_switch_out>;
+ usb_hs_out: endpoint {
+ remote-endpoint = <&pmic_typec_hs_in>;
};
};
};
@@ -222,8 +229,19 @@ examples:
usb-phy {
orientation-switch;
port {
- usb_phy_typec_mux_in: endpoint {
- remote-endpoint = <&pmic_typec_mux_out>;
+ usb_phy_typec_ss_out: endpoint {
+ remote-endpoint = <&pmic_typec_ss_in>;
+ };
+ };
+ };
+
+ usb-mux {
+ orientation-switch;
+ mode-switch;
+
+ port {
+ usb_mux_sbu: endpoint {
+ remote-endpoint = <&pmic_typec_sbu>;
};
};
};

---
base-commit: 4eab358930711bbeb85bf5ee267d0d42d3394c2c
change-id: 20240322-typec-fix-example-3d9b1eca853d

Best regards,
--
Dmitry Baryshkov <[email protected]>

2024-04-19 16:18:27

by Krzysztof Kozlowski

Subject: Re: [PATCH v3] dt-bindings: usb: qcom,pmic-typec: update example to follow connector schema

On 18/04/2024 08:38, Dmitry Baryshkov wrote:
> Update Qualcomm PMIC Type-C examples to follow the USB-C connector
> schema. The USB-C connector should have three ports (USB HS @0,
> SSTX/RX @1 and SBU @2 lanes). Reorder ports accordingly and add SBU port
> connected to the SBU mux (e.g. FSA4480).
>
> Reported-by: Luca Weiss <[email protected]>
> Acked-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Dmitry Baryshkov <[email protected]>
> ---

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof