2024-04-18 14:06:13

by Konstantin Pugin

Subject: [PATCH v2 2/3] serial: sc16is7xx: Add bindings documentation for EXAR XR20M1172 UART

From: Konstantin Pugin <[email protected]>

This patch adds the devicetree documentation for the XR20M1172 UART.

Reviewed-by: Vladimir Zapolskiy <[email protected]>
Signed-off-by: Konstantin Pugin <[email protected]>
---
Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
index 5dec15b7e7c3..68fe7b11961c 100644
--- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
+++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.yaml
@@ -18,6 +18,7 @@ properties:
- nxp,sc16is752
- nxp,sc16is760
- nxp,sc16is762
+ - exar,xr20m1172

reg:
maxItems: 1
--
2.34.1

2024-04-18 14:16:27

by Andy Shevchenko

Subject: Re: [PATCH v2 2/3] serial: sc16is7xx: Add bindings documentation for EXAR XR20M1172 UART

On Thu, Apr 18, 2024 at 04:57:33PM +0300, Konstantin Pugin wrote:
> From: Konstantin Pugin <[email protected]>
>
> This patch adds the devicetree documentation for the XR20M1172 UART.

Submitting Patches document says something about "imperative mood", please
read that document in full anyway as it has a lot of nice requirements and
recommendations.

..

> - nxp,sc16is752
> - nxp,sc16is760
> - nxp,sc16is762
> + - exar,xr20m1172

Wouldn't it be better to keep it alphabetically ordered (at least avoid
bringing more chaos if it's not ordered originally)?

--
With Best Regards,
Andy Shevchenko