Both the CRD and the QCP have the data-lanes and the link-frequencies
for the DP3 in the wrong place. Both are properties of the out remote
endpoint. So move them to the mdss_dp3_out for each board.
Without these fixes, the eDP is broken on both boards.
Signed-off-by: Abel Vesa <[email protected]>
---
Changes in v2:
- Dropped blank line left above the removed link-frequencies in
mdss_dp3_in node, spotted by Konrad
- Dropped the "Display is broken ..." part from the first commit
message
- Added Konrad's R-b tags to all patches
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Abel Vesa (3):
arm64: dts: qcom: x1e80100: Drop the link-frequencies from mdss_dp3_in
arm64: dts: qcom: x1e80100-crd: Add data-lanes and link-frequencies to DP3
arm64: dts: qcom: x1e80100-qcp: Add data-lanes and link-frequencies to DP3
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 5 +++--
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 5 +++--
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 2 --
3 files changed, 6 insertions(+), 6 deletions(-)
---
base-commit: a35e92ef04c07bd473404b9b73d489aea19a60a8
change-id: 20240418-x1e80100-dts-fix-mdss-dp3-c2345ee3ee2f
Best regards,
--
Abel Vesa <[email protected]>
The data-lanes are a property of the out remote endpoint, so move them
from mdss_dp3 to the mdss_dp3_out. Also add the link-frequencies to
mdss_dp3_out and make sure to include all frequencies.
Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Abel Vesa <[email protected]>
---
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 35580ac3430d..2061fbe7b75a 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -410,8 +410,6 @@ &mdss_dp3 {
compatible = "qcom,x1e80100-dp";
/delete-property/ #sound-dai-cells;
- data-lanes = <0 1 2 3>;
-
status = "okay";
aux-bus {
@@ -431,6 +429,9 @@ ports {
port@1 {
reg = <1>;
mdss_dp3_out: endpoint {
+ data-lanes = <0 1 2 3>;
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+
remote-endpoint = <&edp_panel_in>;
};
};
--
2.34.1
The data-lanes are a property of the out remote endpoint, so move them
from mdss_dp3 to the mdss_dp3_out. Also add the link-frequencies to
mdss_dp3_out and make sure to include all frequencies.
Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
Reviewed-by: Konrad Dybcio <[email protected]>
Signed-off-by: Abel Vesa <[email protected]>
---
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
index d4198fa204fd..c5c2895b37c7 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
@@ -599,8 +599,6 @@ &mdss_dp3 {
compatible = "qcom,x1e80100-dp";
/delete-property/ #sound-dai-cells;
- data-lanes = <0 1 2 3>;
-
status = "okay";
aux-bus {
@@ -620,6 +618,9 @@ ports {
port@1 {
reg = <1>;
mdss_dp3_out: endpoint {
+ data-lanes = <0 1 2 3>;
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+
remote-endpoint = <&edp_panel_in>;
};
};
--
2.34.1
On Fri, 19 Apr 2024 at 19:14, Abel Vesa <[email protected]> wrote:
>
> The data-lanes are a property of the out remote endpoint, so move them
> from mdss_dp3 to the mdss_dp3_out. Also add the link-frequencies to
> mdss_dp3_out and make sure to include all frequencies.
>
> Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
> Reviewed-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <[email protected]>
--
With best wishes
Dmitry
On Fri, 19 Apr 2024 at 19:14, Abel Vesa <[email protected]> wrote:
>
> The data-lanes are a property of the out remote endpoint, so move them
> from mdss_dp3 to the mdss_dp3_out. Also add the link-frequencies to
> mdss_dp3_out and make sure to include all frequencies.
>
> Fixes: f9a9c11471da ("arm64: dts: qcom: x1e80100-qcp: Enable more support")
> Reviewed-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Dmitry Baryshkov <[email protected]>
--
With best wishes
Dmitry
On Fri, 19 Apr 2024 19:13:55 +0300, Abel Vesa wrote:
> Both the CRD and the QCP have the data-lanes and the link-frequencies
> for the DP3 in the wrong place. Both are properties of the out remote
> endpoint. So move them to the mdss_dp3_out for each board.
>
> Without these fixes, the eDP is broken on both boards.
>
>
> [...]
Applied, thanks!
[1/3] arm64: dts: qcom: x1e80100: Drop the link-frequencies from mdss_dp3_in
commit: 8a2a43a978e51bcddfe8a89bb2acebcf24f1d767
[2/3] arm64: dts: qcom: x1e80100-crd: Add data-lanes and link-frequencies to DP3
commit: 2351d205081cf4e7d960c0dbc5891e5fbda0b1f0
[3/3] arm64: dts: qcom: x1e80100-qcp: Add data-lanes and link-frequencies to DP3
commit: 78a4407ca834cc448cb015e714ca230ec6bb4503
Best regards,
--
Bjorn Andersson <[email protected]>