2024-04-19 05:56:29

by Liuye

[permalink] [raw]
Subject: Re: Re: Re:[PATCH V11] kdb: Fix the deadloc k issue in KDB debugging.

>On Wed, Apr 17, 2024 at 11:01:56AM +0000, Liuye wrote:
>> >---
>> >V10 -> V11: Revert to V9
>> >V9 -> V10 : Add Signed-off-by of Greg KH and Andy Shevchenko, Acked
>> > by of Daniel Thompson
>> >V8 -> V9: Modify call trace format and move irq_work.h before module.h
>> >V7 -> V8: Update the description information and comments in the code.
>> > : Submit this patch based on version linux-6.9-rc2.
>> >V6 -> V7: Add comments in the code.
>> >V5 -> V6: Replace with a more professional and accurate answer.
>> >V4 -> V5: Answer why schedule another work in the irq_work and not do
>> > the job directly.
>> >V3 -> V4: Add changelogs
>> >V2 -> V3: Add description information
>> >V1 -> V2: using irq_work to solve this properly.
>> >---
>>
>> What is the current status of PATCH V11? Are there any additional
>> modifications needed?
>
>I understood that is blocked pending outcome of the legal matters
>raised by v10... and that this is why you were asked not to post
>v11 until they had been resolved.
>
>To be honest given that [I wrote all of the C code][1] for the most
>recent version of the patch and that I'd like to see the bug fixed,
>then I will probably have to give up on co-authorship. Instead I can
>post my code with a new comment and patch description and credit you
>with a Reported-by:. That should take the pressure off in terms of
>landing this bug fix.

@Daniel

Yes, you can do it this way. To fix this bug as soon as possible, follow what you said. I agree.

>However, the legal issues do still need to be resolved or there is a
>risk that other upstream contributions from your company will be
>delayed.

@Greg KH

This issue still needs to be resolved, but I don't know how to do it.
Please tell me an effective strategy. How should feedback be given to make it effective for you?
There is already an approval process for external emails in the current company.
And a review mechanism has been added within the team. And internal training is provided.
The previous mentioned has been completed. What else needs to be done?

Thanks
Liu Ye


2024-04-19 06:06:54

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: Re: Re:[PATC H V11] kdb: Fix the deadlock issue in KDB debugging.

On Fri, Apr 19, 2024 at 05:54:58AM +0000, Liuye wrote:
> @Greg KH
>
> This issue still needs to be resolved, but I don't know how to do it.
> Please tell me an effective strategy. How should feedback be given to make it effective for you?
> There is already an approval process for external emails in the current company.
> And a review mechanism has been added within the team. And internal training is provided.
> The previous mentioned has been completed. What else needs to be done?

What would you want to see if you were in my position here?

Some sort of "proof" that this really is the case? A discussion with
your company legal group about this? A discussion with your legal group
and the open source legal community about how they have structured all
of this so that it will not happen again and a discussion about how this
did happen (i.e. a blameless post-mortum)? A signed-off-by on your next
patch from a lawyer in that group?

In other words, what does your legal group think would be sufficient
here?

thanks,

greg k-h