2024-04-22 09:08:46

by FLAVIO SULIGOI

[permalink] [raw]
Subject: [PATCH v3 0/5] arm64: dts: remove tx-sched-sp property in snps,dwmac

In the ethernet stmmac device driver:

- drivers/net/ethernet/stmicro/stmmac/

The "Strict priority" for the tx scheduler is by default in Linux driver,
so the tx-sched-sp property was removed in commit aed6864035b1 ("net:
stmmac: platform: Delete a redundant condition branch").

This patch series remove this property from the following device-tree
files:

- arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
- arch/arm64/boot/dts/freescale/imx8mp-evk.dts
- arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
- arch/arm64/boot/dts/qcom/sa8540p-ride.dts
- arch/arm64/boot/dts/qcom/sa8775p-ride.dts

There is no problem if that property is still used in these DTS,
since, as seen above, it is a default property of the driver.

The property is also removed, in a separate patch, from the corresponding
dt_bindings file:
- Documentation/devicetree/bindings/net/snps,dwmac.yaml

v3 - Removed the tag "Reviewed-by: Krzysztof Kozlowski <[email protected]>"
in patches num. 1/5, 2/5, 3/5 and 5/5 (it was added by mistake).
Added history in each of the patches, as well as in the cover-letter.
v2 - This patch is the 2nd version of a previous patch, where both the DTS
and the yaml files were included toghether. Then I split this 1st
patch series in two, as suggested by Krzysztof.
v1 - Original version of the patch where, in addition to these DTS patches,
there was also the one related to the correspondent snps,dwmac.yaml
dt_binding file.

Flavio Suligoi (5):
arm64: dts: freescale: imx8mp-beacon: remove tx-sched-sp property
arm64: dts: freescale: imx8mp-evk: remove tx-sched-sp property
arm64: dts: freescale: imx8mp-verdin: remove tx-sched-sp property
arm64: dts: qcom: sa8540p-ride: remove tx-sched-sp property
arm64: dts: qcom: sa8775p-ride: remove tx-sched-sp property

arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi | 1 -
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 1 -
arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 1 -
arch/arm64/boot/dts/qcom/sa8540p-ride.dts | 2 --
arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 2 --
5 files changed, 7 deletions(-)

--
2.34.1



2024-04-22 09:09:46

by FLAVIO SULIGOI

[permalink] [raw]
Subject: [PATCH v3 5/5] arm64: dts: qcom: sa8775p-ride: remove tx-sched-sp property

Strict priority for the tx scheduler is by default in Linux driver, so the
tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
platform: Delete a redundant condition branch").

So we can safely remove this property from this device-tree.

Signed-off-by: Flavio Suligoi <[email protected]>
---

v3 - Removed the tag "Reviewed-by: Krzysztof Kozlowski <[email protected]>"
(it was added by mistake).
Added history, as well as in the cover-letter.
v2 - This patch is the 2nd version of a previous patch, where both the DTS
and the yaml files were included toghether. Then I split this 1st patch
series in two, as suggested by Krzysztof.
v1 - Original version of the patch where, in addition to this DTS patch,
there was also the one related to the correspondent snps,dwmac.yaml
dt_binding file.

arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index 26ad05bd3b3f..2e1770e07f45 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -334,7 +334,6 @@ queue3 {

mtl_tx_setup: tx-queues-config {
snps,tx-queues-to-use = <4>;
- snps,tx-sched-sp;

queue0 {
snps,dcb-algorithm;
@@ -404,7 +403,6 @@ queue3 {

mtl_tx_setup1: tx-queues-config {
snps,tx-queues-to-use = <4>;
- snps,tx-sched-sp;

queue0 {
snps,dcb-algorithm;
--
2.34.1


2024-04-22 09:10:19

by FLAVIO SULIGOI

[permalink] [raw]
Subject: [PATCH v3 2/5] arm64: dts: freescale: imx8mp-evk: remove tx-sched-sp property

Strict priority for the tx scheduler is by default in Linux driver, so the
tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
platform: Delete a redundant condition branch").

So we can safely remove this property from this device-tree.

Signed-off-by: Flavio Suligoi <[email protected]>
---

v3 - Removed the tag "Reviewed-by: Krzysztof Kozlowski <[email protected]>"
(it was added by mistake).
Added history, as well as in the cover-letter.
v2 - This patch is the 2nd version of a previous patch, where both the DTS
and the yaml files were included toghether. Then I split this 1st patch
series in two, as suggested by Krzysztof.
v1 - Original version of the patch where, in addition to this DTS patch,
there was also the one related to the correspondent snps,dwmac.yaml
dt_binding file.

arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 9beba8d6a0df..8747c86689cc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -226,7 +226,6 @@ ethphy0: ethernet-phy@1 {

mtl_tx_setup: tx-queues-config {
snps,tx-queues-to-use = <5>;
- snps,tx-sched-sp;

queue0 {
snps,dcb-algorithm;
--
2.34.1


2024-04-22 09:10:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: sa8775p-ride: remove tx-sched-sp property

On 22/04/2024 11:04, Flavio Suligoi wrote:
> Strict priority for the tx scheduler is by default in Linux driver, so the
> tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
> platform: Delete a redundant condition branch").
>
> So we can safely remove this property from this device-tree.
>
> Signed-off-by: Flavio Suligoi <[email protected]>
> ---


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-04-22 09:17:29

by FLAVIO SULIGOI

[permalink] [raw]
Subject: [PATCH v3 1/5] arm64: dts: freescale: imx8mp-beacon: remove tx-sched-sp property

Strict priority for the tx scheduler is by default in Linux driver, so the
tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
platform: Delete a redundant condition branch").

So we can safely remove this property from this device-tree.

Signed-off-by: Flavio Suligoi <[email protected]>
---

v3 - Removed the tag "Reviewed-by: Krzysztof Kozlowski <[email protected]>"
(it was added by mistake).
Added history, as well as in the cover-letter.
v2 - This patch is the 2nd version of a previous patch, where both the DTS
and the yaml files were included toghether. Then I split this 1st patch
series in two, as suggested by Krzysztof.
v1 - Original version of the patch where, in addition to this DTS patch,
there was also the one related to the correspondent snps,dwmac.yaml
dt_binding file.

arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
index 8be251b69378..34339dc4a635 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-som.dtsi
@@ -106,7 +106,6 @@ queue4 {

mtl_tx_setup: tx-queues-config {
snps,tx-queues-to-use = <5>;
- snps,tx-sched-sp;

queue0 {
snps,dcb-algorithm;
--
2.34.1


2024-04-22 09:18:19

by FLAVIO SULIGOI

[permalink] [raw]
Subject: [PATCH v3 3/5] arm64: dts: freescale: imx8mp-verdin: remove tx-sched-sp property

Strict priority for the tx scheduler is by default in Linux driver, so the
tx-sched-sp property was removed in commit aed6864035b1 ("net: stmmac:
platform: Delete a redundant condition branch").

So we can safely remove this property from this device-tree.

Signed-off-by: Flavio Suligoi <[email protected]>
---

v3 - Removed the tag "Reviewed-by: Krzysztof Kozlowski <[email protected]>"
(it was added by mistake).
Added history, as well as in the cover-letter.
v2 - This patch is the 2nd version of a previous patch, where both the DTS
and the yaml files were included toghether. Then I split this 1st patch
series in two, as suggested by Krzysztof.
v1 - Original version of the patch where, in addition to this DTS patch,
there was also the one related to the correspondent snps,dwmac.yaml
dt_binding file.

arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index faa17cbbe2fd..21d4b6a9a1af 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -260,7 +260,6 @@ queue4 {

mtl_tx_setup: tx-queues-config {
snps,tx-queues-to-use = <5>;
- snps,tx-sched-sp;

queue0 {
snps,dcb-algorithm;
--
2.34.1