2024-04-23 20:56:32

by Barnabás Czémán

Subject: [PATCH] drm/panel: jdi-fhd-r63452: make use of prepare_prev_first

The DSI host must be enabled for the panel to be initialized in
prepare(). Set the prepare_prev_first flag to guarantee this.

Signed-off-by: Barnabás Czémán <[email protected]>
---
drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
index 3e0a8e0d58a0..483dc88d16d8 100644
--- a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
+++ b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
@@ -247,6 +247,7 @@ static int jdi_fhd_r63452_probe(struct mipi_dsi_device *dsi)

drm_panel_init(&ctx->panel, dev, &jdi_fhd_r63452_panel_funcs,
DRM_MODE_CONNECTOR_DSI);
+ ctx->panel.prepare_prev_first = true;

ret = drm_panel_of_backlight(&ctx->panel);
if (ret)

---
base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8
change-id: 20240423-jdi-fix-986a796a3101

Best regards,
--
Barnabás Czémán <[email protected]>

2024-04-24 06:51:30

by Neil Armstrong

Subject: Re: [PATCH] drm/panel: jdi-fhd-r63452: make use of prepare_prev_first

On 23/04/2024 22:54, Barnabás Czémán wrote:
> The DSI host must be enabled for the panel to be initialized in
> prepare(). Set the prepare_prev_first flag to guarantee this.
>
> Signed-off-by: Barnabás Czémán <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
> index 3e0a8e0d58a0..483dc88d16d8 100644
> --- a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
> +++ b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c
> @@ -247,6 +247,7 @@ static int jdi_fhd_r63452_probe(struct mipi_dsi_device *dsi)
>
> drm_panel_init(&ctx->panel, dev, &jdi_fhd_r63452_panel_funcs,
> DRM_MODE_CONNECTOR_DSI);
> + ctx->panel.prepare_prev_first = true;
>
> ret = drm_panel_of_backlight(&ctx->panel);
> if (ret)
>
> ---
> base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8
> change-id: 20240423-jdi-fix-986a796a3101
>
> Best regards,

Reviewed-by: Neil Armstrong <[email protected]>

2024-04-24 07:01:15

by Neil Armstrong

Subject: Re: [PATCH] drm/panel: jdi-fhd-r63452: make use of prepare_prev_first

Hi,

On Tue, 23 Apr 2024 22:54:33 +0200, Barnabás Czémán wrote:
> The DSI host must be enabled for the panel to be initialized in
> prepare(). Set the prepare_prev_first flag to guarantee this.
>
>

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/1] drm/panel: jdi-fhd-r63452: make use of prepare_prev_first
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/4edd73d174de5e8ec43f0de303f4a8b80e643529

--
Neil