2024-04-23 17:03:26

by Tanmay Shah

Subject: [PATCH] drivers: remoteproc: xlnx: fix uninitialize variable use

Fix following warning for clang compiler with W=1 option:
initialize the variable 'ret' to silence this warning
907 | int ret, i;
| ^
| = 0

Fixes: a6b974b40f94 ("drivers: remoteproc: xlnx: Add Versal and Versal-NET support")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Tanmay Shah <[email protected]>
---
drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
index a6d8ac7394e7..d98940d7ef8f 100644
--- a/drivers/remoteproc/xlnx_r5_remoteproc.c
+++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
@@ -904,7 +904,7 @@ static int zynqmp_r5_core_init(struct zynqmp_r5_cluster *cluster,
{
struct device *dev = cluster->dev;
struct zynqmp_r5_core *r5_core;
- int ret, i;
+ int ret = -EINVAL, i;

r5_core = cluster->r5_cores[0];


base-commit: e99fcac055b3325283d6c5c61a117651fb147686
--
2.25.1

2024-04-23 19:33:38

by Mathieu Poirier

Subject: Re: [PATCH] drivers: remoteproc: xlnx: fix uninitialize variable use

On Tue, Apr 23, 2024 at 10:02:11AM -0700, Tanmay Shah wrote:
> Fix following warning for clang compiler with W=1 option:
> initialize the variable 'ret' to silence this warning
> 907 | int ret, i;
> | ^
> | = 0
>
> Fixes: a6b974b40f94 ("drivers: remoteproc: xlnx: Add Versal and Versal-NET support")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Tanmay Shah <[email protected]>
> ---
> drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.c b/drivers/remoteproc/xlnx_r5_remoteproc.c
> index a6d8ac7394e7..d98940d7ef8f 100644
> --- a/drivers/remoteproc/xlnx_r5_remoteproc.c
> +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c
> @@ -904,7 +904,7 @@ static int zynqmp_r5_core_init(struct zynqmp_r5_cluster *cluster,
> {
> struct device *dev = cluster->dev;
> struct zynqmp_r5_core *r5_core;
> - int ret, i;
> + int ret = -EINVAL, i;
>

Applied - thanks,
Mathieu

> r5_core = cluster->r5_cores[0];
>
>
> base-commit: e99fcac055b3325283d6c5c61a117651fb147686
> --
> 2.25.1
>