2024-04-23 18:50:21

by Andy Shevchenko

Subject: [PATCH v1 1/1] fbtft: seps525: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use)
principle.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/staging/fbtft/fb_seps525.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/fbtft/fb_seps525.c b/drivers/staging/fbtft/fb_seps525.c
index 05882e2cde7f..46c257308b49 100644
--- a/drivers/staging/fbtft/fb_seps525.c
+++ b/drivers/staging/fbtft/fb_seps525.c
@@ -16,11 +16,10 @@
* GNU General Public License for more details.
*/

-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/init.h>
-#include <linux/gpio.h>
+#include <linux/bits.h>
#include <linux/delay.h>
+#include <linux/init.h>
+#include <linux/module.h>

#include "fbtft.h"

--
2.43.0.rc1.1336.g36b5255a03ac

2024-04-27 00:34:06

by Hennerich, Michael

Subject: RE: [PATCH v1 1/1] fbtft: seps525: Don't use "proxy" headers

> -----Original Message-----
> From: Andy Shevchenko <[email protected]>
> Sent: Tuesday, April 23, 2024 1:36 PM
> To: Andy Shevchenko <[email protected]>; linux-
> [email protected]; [email protected]; linux-
> [email protected]; [email protected]
> Cc: Hennerich, Michael <[email protected]>; Greg Kroah-
> Hartman <[email protected]>; Helge Deller <[email protected]>
> Subject: [PATCH v1 1/1] fbtft: seps525: Don't use "proxy" headers
>
> Update header inclusions to follow IWYU (Include What You Use) principle.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Acked-by: Michael Hennerich <[email protected]>

> ---
> drivers/staging/fbtft/fb_seps525.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_seps525.c
> b/drivers/staging/fbtft/fb_seps525.c
> index 05882e2cde7f..46c257308b49 100644
> --- a/drivers/staging/fbtft/fb_seps525.c
> +++ b/drivers/staging/fbtft/fb_seps525.c
> @@ -16,11 +16,10 @@
> * GNU General Public License for more details.
> */
>
> -#include <linux/module.h>
> -#include <linux/kernel.h>
> -#include <linux/init.h>
> -#include <linux/gpio.h>
> +#include <linux/bits.h>
> #include <linux/delay.h>
> +#include <linux/init.h>
> +#include <linux/module.h>
>
> #include "fbtft.h"
>
> --
> 2.43.0.rc1.1336.g36b5255a03ac